Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92BF1C433DF for ; Wed, 15 Jul 2020 18:38:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7DE592064B for ; Wed, 15 Jul 2020 18:38:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726898AbgGOSiv (ORCPT ); Wed, 15 Jul 2020 14:38:51 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:37358 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726465AbgGOSiv (ORCPT ); Wed, 15 Jul 2020 14:38:51 -0400 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1jvmIl-005HNy-E8; Wed, 15 Jul 2020 20:38:43 +0200 Date: Wed, 15 Jul 2020 20:38:43 +0200 From: Andrew Lunn To: Russell King Cc: Richard Cochran , Florian Fainelli , Heiner Kallweit , "David S. Miller" , Jakub Kicinski , netdev@vger.kernel.org Subject: Re: [PATCH RFC net-next] net: phy: add Marvell PHY PTP support Message-ID: <20200715183843.GA1256692@lunn.ch> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > Getting the Kconfig for this correct has been a struggle - particularly > the combination where PTP support is modular. It's rather odd to have > the Marvell PTP support asked before the Marvell PHY support. I > couldn't work out any other reasonable way to ensure that we always > have a valid configuration, without leading to stupidities such as > having the PTP and Marvell PTP support modular, but non-functional > because Marvell PHY is built-in. Hi Russell How much object code is this adding? All the other PHYs which support PTP just make it part of the PHY driver, not a standalone module. That i guess simplifies the conditions. Looking at DSDT, it lists case MAD_88E1340S: case MAD_88E1340: case MAD_88E1340M: case MAD_SWG65G : case MAD_88E151x: as being MAD_PHY_PTP_TAI_CAPABLE; and case MAD_88E1548 case MAD_88E1680: case MAD_88E1680M: as MAD_PHY_1STEP_PTP_CAPABLE; So maybe we can wire this up to a few more PHYs to 'lower' the overhead a bit? > It seems that the Marvell PHY PTP is very similar to that found in > their DSA chips, which suggests maybe we should share the code, but > different access methods would be required. That makes the Kconfig even more complex :-( Andrew