From: Tom Rini Date: Fri, 17 Jul 2020 16:58:00 -0400 Subject: [PATCH 1/3] treewide: convert bd_t to struct bd_info by coccinelle In-Reply-To: <20200626061335.1611120-1-masahiroy@kernel.org> References: <20200626061335.1611120-1-masahiroy@kernel.org> Message-ID: <20200717205800.GX6227@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Fri, Jun 26, 2020 at 03:13:33PM +0900, Masahiro Yamada wrote: > The Linux coding style guide (Documentation/process/coding-style.rst) > clearly says: > > It's a **mistake** to use typedef for structures and pointers. > > Besides, using typedef for structures is annoying when you try to make > headers self-contained. > > Let's say you have the following function declaration in a header: > > void foo(bd_t *bd); > > This is not self-contained since bd_t is not defined. > > To tell the compiler what 'bd_t' is, you need to include > > #include > void foo(bd_t *bd); > > Then, the include direcective pulls in more bloat needlessly. > > If you use 'struct bd_info' instead, it is enough to put a forward > declaration as follows: > > struct bd_info; > void foo(struct bd_info *bd); > > Right, typedef'ing bd_t is a mistake. > > I used coccinelle to generate this commit. > > The semantic patch that makes this change is as follows: > > > @@ > typedef bd_t; > @@ > -bd_t > +struct bd_info > > > Signed-off-by: Masahiro Yamada Applied to u-boot/master, thanks! -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: