Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B3BEC433E2 for ; Sat, 18 Jul 2020 13:08:28 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DA57C20684 for ; Sat, 18 Jul 2020 13:08:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DA57C20684 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 52D766E087; Sat, 18 Jul 2020 13:08:27 +0000 (UTC) Received: from asavdk4.altibox.net (asavdk4.altibox.net [109.247.116.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9E5736E087; Sat, 18 Jul 2020 13:08:24 +0000 (UTC) Received: from ravnborg.org (unknown [188.228.123.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk4.altibox.net (Postfix) with ESMTPS id 9C4D280513; Sat, 18 Jul 2020 15:08:21 +0200 (CEST) Date: Sat, 18 Jul 2020 15:08:19 +0200 From: Sam Ravnborg To: Anitha Chrisanthus Subject: Re: [PATCH v3] drm/kmb: Add support for KeemBay Display Message-ID: <20200718130819.GA2990383@ravnborg.org> References: <1595020551-30768-1-git-send-email-anitha.chrisanthus@intel.com> <1595020551-30768-2-git-send-email-anitha.chrisanthus@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1595020551-30768-2-git-send-email-anitha.chrisanthus@intel.com> X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=aP3eV41m c=1 sm=1 tr=0 a=S6zTFyMACwkrwXSdXUNehg==:117 a=S6zTFyMACwkrwXSdXUNehg==:17 a=8nJEP1OIZ-IA:10 a=QyXUC8HyAAAA:8 a=e5mUnYsNAAAA:8 a=NbUQyiW4ozcTRDWNEbYA:9 a=7Zwj6sZBwVKJAoWSPKxL6X1jA+E=:19 a=A-cRaIRomaI41WbL:21 a=f6OysZVNCLMOZr4t:21 a=KCvXBQXxo3Az3Huz:21 a=wPNLvfGTeEIA:10 a=Vxmtnl_E_bksehYqCbjh:22 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, edmund.j.dea@intel.com, dri-devel@lists.freedesktop.org, rodrigo.vivi@intel.com, daniel.vetter@intel.com Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Anitha. On Fri, Jul 17, 2020 at 02:15:51PM -0700, Anitha Chrisanthus wrote: > This is a basic KMS atomic modesetting display driver for KeemBay family = of > SOCs. Driver has no 2D or 3D graphics.It calls into the ADV bridge > driver at the connector level. > = > Single CRTC with LCD controller->mipi DSI-> ADV bridge > = > Only 1080p resolution and single plane is supported at this time. > = > v2: moved extern to .h, removed license text > use drm_dev_init, upclassed dev_private, removed HAVE_IRQ. > = > v3: Squashed all 59 commits to one > = > Signed-off-by: Anitha Chrisanthus > Reviewed-by: Bob Paauwe This was much easier to look into with it all squashed together. See comments scattered in the following. The only major feedback is that kmb_dsi really looks like something that should be implemented as a real bridge driver. Lots of small details to bring the driver up to the current standard. And other bits I noted while browsing the code. Sam > --- > drivers/gpu/drm/Kconfig | 2 + > drivers/gpu/drm/Makefile | 1 + > drivers/gpu/drm/kmb/Kconfig | 12 + > drivers/gpu/drm/kmb/Makefile | 2 + > drivers/gpu/drm/kmb/kmb_crtc.c | 219 +++++ > drivers/gpu/drm/kmb/kmb_crtc.h | 41 + > drivers/gpu/drm/kmb/kmb_drv.c | 759 ++++++++++++++++ > drivers/gpu/drm/kmb/kmb_drv.h | 165 ++++ > drivers/gpu/drm/kmb/kmb_dsi.c | 1833 +++++++++++++++++++++++++++++++++= ++++++ > drivers/gpu/drm/kmb/kmb_dsi.h | 370 ++++++++ > drivers/gpu/drm/kmb/kmb_plane.c | 515 +++++++++++ > drivers/gpu/drm/kmb/kmb_plane.h | 124 +++ > drivers/gpu/drm/kmb/kmb_regs.h | 738 ++++++++++++++++ > 13 files changed, 4781 insertions(+) > create mode 100644 drivers/gpu/drm/kmb/Kconfig > create mode 100644 drivers/gpu/drm/kmb/Makefile > create mode 100644 drivers/gpu/drm/kmb/kmb_crtc.c > create mode 100644 drivers/gpu/drm/kmb/kmb_crtc.h > create mode 100644 drivers/gpu/drm/kmb/kmb_drv.c > create mode 100644 drivers/gpu/drm/kmb/kmb_drv.h > create mode 100644 drivers/gpu/drm/kmb/kmb_dsi.c > create mode 100644 drivers/gpu/drm/kmb/kmb_dsi.h > create mode 100644 drivers/gpu/drm/kmb/kmb_plane.c > create mode 100644 drivers/gpu/drm/kmb/kmb_plane.h > create mode 100644 drivers/gpu/drm/kmb/kmb_regs.h > = > diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig > index c4fd57d..5292574 100644 > --- a/drivers/gpu/drm/Kconfig > +++ b/drivers/gpu/drm/Kconfig > @@ -275,6 +275,8 @@ source "drivers/gpu/drm/nouveau/Kconfig" > = > source "drivers/gpu/drm/i915/Kconfig" > = > +source "drivers/gpu/drm/kmb/Kconfig" > + > config DRM_VGEM > tristate "Virtual GEM provider" > depends on DRM > diff --git a/drivers/gpu/drm/Makefile b/drivers/gpu/drm/Makefile > index 2c0e5a7..bdbdc63 100644 > --- a/drivers/gpu/drm/Makefile > +++ b/drivers/gpu/drm/Makefile > @@ -71,6 +71,7 @@ obj-$(CONFIG_DRM_AMDGPU)+=3D amd/amdgpu/ > obj-$(CONFIG_DRM_MGA) +=3D mga/ > obj-$(CONFIG_DRM_I810) +=3D i810/ > obj-$(CONFIG_DRM_I915) +=3D i915/ > +obj-$(CONFIG_DRM_KMB_DISPLAY) +=3D kmb/ > obj-$(CONFIG_DRM_MGAG200) +=3D mgag200/ > obj-$(CONFIG_DRM_V3D) +=3D v3d/ > obj-$(CONFIG_DRM_VC4) +=3D vc4/ > diff --git a/drivers/gpu/drm/kmb/Kconfig b/drivers/gpu/drm/kmb/Kconfig > new file mode 100644 > index 0000000..005a9962 > --- /dev/null > +++ b/drivers/gpu/drm/kmb/Kconfig > @@ -0,0 +1,12 @@ > +config DRM_KMB_DISPLAY > + tristate "KEEMBAY DISPLAY" > + depends on DRM && OF && (ARM || ARM64) > + depends on COMMON_CLK > + select DRM_KMS_HELPER > + select DRM_KMS_CMA_HELPER > + select DRM_GEM_CMA_HELPER > + select VIDEOMODE_HELPERS > + help > + Choose this option if you have an KEEMBAY DISPLAY controller. > + > + If M is selected the module will be called kmb-display. It would be good if you could elaborate just a bit more here. Just so users knows a bit more what it is. For example I think most users will not know this is something from Intel. Also I think the module is not named kmb-display, so this needs to be addressed. > diff --git a/drivers/gpu/drm/kmb/Makefile b/drivers/gpu/drm/kmb/Makefile > new file mode 100644 > index 0000000..527d737 > --- /dev/null > +++ b/drivers/gpu/drm/kmb/Makefile > @@ -0,0 +1,2 @@ > +kmb-drm-y :=3D kmb_crtc.o kmb_drv.o kmb_plane.o kmb_dsi.o > +obj-$(CONFIG_DRM_KMB_DISPLAY) +=3D kmb-drm.o > diff --git a/drivers/gpu/drm/kmb/kmb_crtc.c b/drivers/gpu/drm/kmb/kmb_crt= c.c > new file mode 100644 > index 0000000..570d46e > --- /dev/null > +++ b/drivers/gpu/drm/kmb/kmb_crtc.c > @@ -0,0 +1,219 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/* > + * Copyright =A9 2018-2020 Intel Corporation > + */ > + > +#include > +#include > +#include > +#include