Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DB8FC433E0 for ; Sun, 19 Jul 2020 15:27:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 22CBB22B51 for ; Sun, 19 Jul 2020 15:27:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726505AbgGSP1d (ORCPT ); Sun, 19 Jul 2020 11:27:33 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:43540 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726038AbgGSP1d (ORCPT ); Sun, 19 Jul 2020 11:27:33 -0400 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1jxBDn-005szR-Ol; Sun, 19 Jul 2020 17:27:23 +0200 Date: Sun, 19 Jul 2020 17:27:23 +0200 From: Andrew Lunn To: Russell King Cc: Florian Fainelli , Heiner Kallweit , Martin Rowe , "David S. Miller" , devicetree@vger.kernel.org, Gregory Clement , Jakub Kicinski , Jason Cooper , linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, Rob Herring , Sebastian Hesselbarth , Vivien Didelot Subject: Re: [PATCH net] arm64: dts: clearfog-gt-8k: fix switch link configuration Message-ID: <20200719152723.GG1383417@lunn.ch> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sun, Jul 19, 2020 at 12:00:40PM +0100, Russell King wrote: > The commit below caused a regression for clearfog-gt-8k, where the link > between the switch and the host does not come up. > > Investigation revealed two issues: > - MV88E6xxx DSA no longer allows an in-band link to come up as the link > is programmed to be forced down. Commit "net: dsa: mv88e6xxx: fix > in-band AN link establishment" addresses this. > > - The dts configured dissimilar link modes at each end of the host to > switch link; the host was configured using a fixed link (so has no > in-band status) and the switch was configured to expect in-band > status. > > With both issues fixed, the regression is resolved. > > Fixes: 34b5e6a33c1a ("net: dsa: mv88e6xxx: Configure MAC when using fixed link") > Reported-by: Martin Rowe > Signed-off-by: Russell King Reviewed-by: Andrew Lunn Andrew