From: Sam Ravnborg Subject: Re: [PATCH v5 14/19] backlight: cr_bllcd: introduce gpio-backlight semantics Date: Mon, 20 Jul 2020 11:14:27 +0200 Message-ID: <20200720091427.GA140081@ravnborg.org> References: <20200719080743.8560-1-sam@ravnborg.org> <20200719080743.8560-15-sam@ravnborg.org> <20200720084822.wt5guzetkrgbgdcc@holly.lan> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from asavdk3.altibox.net ([109.247.116.14]:55006 "EHLO asavdk3.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728017AbgGTJOh (ORCPT ); Mon, 20 Jul 2020 05:14:37 -0400 Content-Disposition: inline In-Reply-To: <20200720084822.wt5guzetkrgbgdcc@holly.lan> Sender: linux-pwm-owner@vger.kernel.org List-Id: linux-pwm@vger.kernel.org To: Daniel Thompson Cc: dri-devel@lists.freedesktop.org, Jingoo Han , Lee Jones , Andy Gross , Bartlomiej Zolnierkiewicz , Bjorn Andersson , Daniel Vetter , David Airlie , Emil Velikov , Jonathan Corbet , linux-arm-msm@vger.kernel.org, linux-pwm@vger.kernel.org, Maarten Lankhorst , Maxime Ripard , Michael Hennerich , patches@opensource.cirrus.com, Support Opensource , Thierry Reding , Thomas Zimmermann , Uwe On Mon, Jul 20, 2020 at 09:48:22AM +0100, Daniel Thompson wrote: > On Sun, Jul 19, 2020 at 10:07:38AM +0200, Sam Ravnborg wrote: > > cr_bllcd can turn backlight ON or OFF. > > Fix semantitics so they equals what we know from gpio-backlight. > > brightness == 0 => backlight off > > brightness == 1 => backlight on > > > > Use the backlight_get_brightness() helper to simplify the code. > > > > v2: > > - reworked to introduce gpio-backlight semantics (Daniel) > > Wasn't this added for v5? However, I spotted this change amoung the > other patches so no worries... I do not increment version for individual patches unless there are changes. So this is the second version of this patch, but included in the v5 submission. But I can see how this can confuse the receiver. I will consider to adapt to the practice to indicate version of submission and not the individual patches. > > > > Signed-off-by: Sam Ravnborg > > Cc: Lee Jones > > Cc: Daniel Thompson > > Cc: Jingoo Han > > Reviewed-by: Daniel Thompson Very much appreciated - thanks! Sam