Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2460AC433E4 for ; Mon, 20 Jul 2020 13:15:25 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DFC7D20729 for ; Mon, 20 Jul 2020 13:15:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="KBo6bw/c"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b="L8hVGwwP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DFC7D20729 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=microchip.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=lyiYULOPnE25FZU+ia/06EOyQAW9Li/scmZOqEnciHs=; b=KBo6bw/cyQ825KEHwKhi0tQty pdzcG5/H12Ig5bizTzrL8sQHS2Dj3BEfctQLvG1D5ryEXoqHHWPIzY4MqYDTSZK5GUtQDKByFqooe Y0vgptd9/5hdWMJXrWyS4yMUrieI3sim2bvHJOIRAgmeYDlqGqxKO2wBDO2MJ6G6JihBNE9dgqG9z Zuy5xAnH7lC/0KCRfGl+t2PmG2Cri0x3Yz4rLWx6WX7AfLqF+t79OIppNeKbQIrHtRuCUQAwCtXhY wMIeRpWkEpzufKH5cUtQCOP64mBBPKmtPDh3DfFTIpnepK58+GQkT6w/QYsFm7AnnVrvixrqcvfYg IihotTX/A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jxVcO-0006wx-6r; Mon, 20 Jul 2020 13:14:08 +0000 Received: from esa5.microchip.iphmx.com ([216.71.150.166]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jxVcJ-0006tp-Ij for linux-mtd@lists.infradead.org; Mon, 20 Jul 2020 13:14:04 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1595250844; x=1626786844; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=EsSY8wLNz6MP+4zdlXMAZf8Iwzxu5mz+tBmkY/uww3U=; b=L8hVGwwPlquKk9jOP/fjFwhbMhwbKCu0uZ5zBE1Kg0mlUtYPiygfSMGn H6642MbqKT6bOmojmkpWh9WMw6csBw3ruiPDDKD8dvs93nMmYLt/IKNII D42t5Lm5466Gpkx1J3IdEOKe99ZpoZO3EUgEkln1iwxFJm8/5o4Aq9ZJ5 PEn6Q792GznN3pFx4ULR1awuWKy+H/0D6+k2TKtjKBAy4opZLiIJlHN9i B7rPhu0tuYxl3nsMqr8pnzXWcGMfNSiSCzDp4DCa5/2l7j8kwTnuQ6gT5 7iTArV0Wkp0LY3nKZ4bVT00JNxD/nwylz8qMhQuU+lHe6Mreqq++aaEH7 g==; IronPort-SDR: +4PmZwGqffvijCcpyjhgCQcYncl5tbgPW88j/lzh2xh/UlgLmo1rZlM8GqriF4gm4PhcTw3CG4 GCbKKQwWpwXGbQCqMjlb10OWCsI1S67vftvYOy17dY/AEExc/9ZMTLKH7bS4L1/WMXuJmh0/zD akHEr+dFjydS+LwN+20KhGTCUPsUwm+CEAl+WOi/FcJaT7ClJ+/Bu/O4gRTogV7Yh1Xin8kl9i zwYHDaztcqP7M26MU1wnCzK3yG2tSOI61wGRQ5amg8EF/IoGu5dghpRWS34qjUqy75SzO7rYTu M4Y= X-IronPort-AV: E=Sophos;i="5.75,375,1589266800"; d="scan'208";a="83873080" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa5.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 20 Jul 2020 06:14:02 -0700 Received: from chn-vm-ex02.mchp-main.com (10.10.85.144) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1979.3; Mon, 20 Jul 2020 06:14:02 -0700 Received: from atudor-ThinkPad-T470p.amer.actel.com (10.10.115.15) by chn-vm-ex02.mchp-main.com (10.10.85.144) with Microsoft SMTP Server id 15.1.1979.3 via Frontend Transport; Mon, 20 Jul 2020 06:13:21 -0700 From: Tudor Ambarus To: , Subject: [PATCH v5 1/6] mtd: rawnand: atmel: Enable the NFC controller at probe time Date: Mon, 20 Jul 2020 16:13:51 +0300 Message-ID: <20200720131356.1579073-2-tudor.ambarus@microchip.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200720131356.1579073-1-tudor.ambarus@microchip.com> References: <20200720131356.1579073-1-tudor.ambarus@microchip.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200720_091403_804631_79930802 X-CRM114-Status: UNSURE ( 8.83 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alexandre.belloni@bootlin.com, ludovic.desroches@microchip.com, linux-mtd@lists.infradead.org, nicolas.ferre@microchip.com, Tudor Ambarus Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org From: Boris Brezillon No need to enable it everytime select_chip() is called. If we really care about PM, we should implement runtime PM hooks and disable the controller and all its clocks when the controller has been unused for some time. Signed-off-by: Boris Brezillon Reviewed-by: Miquel Raynal Reviewed-by: Tudor Ambarus Signed-off-by: Tudor Ambarus --- drivers/mtd/nand/raw/atmel/nand-controller.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/mtd/nand/raw/atmel/nand-controller.c b/drivers/mtd/nand/raw/atmel/nand-controller.c index c9818f548d07..e85652512daa 100644 --- a/drivers/mtd/nand/raw/atmel/nand-controller.c +++ b/drivers/mtd/nand/raw/atmel/nand-controller.c @@ -525,11 +525,8 @@ static void atmel_hsmc_nand_select_chip(struct nand_chip *chip, int cs) atmel_nand_select_chip(chip, cs); - if (!nand->activecs) { - regmap_write(nc->base.smc, ATMEL_HSMC_NFC_CTRL, - ATMEL_HSMC_NFC_CTRL_DIS); + if (!nand->activecs) return; - } if (nand->activecs->rb.type == ATMEL_NAND_NATIVE_RB) chip->legacy.dev_ready = atmel_hsmc_nand_dev_ready; @@ -542,8 +539,6 @@ static void atmel_hsmc_nand_select_chip(struct nand_chip *chip, int cs) ATMEL_HSMC_NFC_CFG_PAGESIZE(mtd->writesize) | ATMEL_HSMC_NFC_CFG_SPARESIZE(mtd->oobsize) | ATMEL_HSMC_NFC_CFG_RSPARE); - regmap_write(nc->base.smc, ATMEL_HSMC_NFC_CTRL, - ATMEL_HSMC_NFC_CTRL_EN); } static int atmel_nfc_exec_op(struct atmel_hsmc_nand_controller *nc, bool poll) @@ -2248,6 +2243,9 @@ atmel_hsmc_nand_controller_remove(struct atmel_nand_controller *nc) return ret; hsmc_nc = container_of(nc, struct atmel_hsmc_nand_controller, base); + regmap_write(hsmc_nc->base.smc, ATMEL_HSMC_NFC_CTRL, + ATMEL_HSMC_NFC_CTRL_DIS); + if (hsmc_nc->sram.pool) gen_pool_free(hsmc_nc->sram.pool, (unsigned long)hsmc_nc->sram.virt, @@ -2300,6 +2298,8 @@ static int atmel_hsmc_nand_controller_probe(struct platform_device *pdev, /* Initial NFC configuration. */ regmap_write(nc->base.smc, ATMEL_HSMC_NFC_CFG, ATMEL_HSMC_NFC_CFG_DTO_MAX); + regmap_write(nc->base.smc, ATMEL_HSMC_NFC_CTRL, + ATMEL_HSMC_NFC_CTRL_EN); ret = atmel_nand_controller_add_nands(&nc->base); if (ret) -- 2.25.1 ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/