From: Christoph Hellwig Subject: Re: io_uring vs in_compat_syscall() Date: Tue, 21 Jul 2020 16:34:12 +0200 Message-ID: <20200721143412.GA8099@lst.de> References: <8987E376-6B13-4798-BDBA-616A457447CF@amacapital.net> <20200721070709.GB11432@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Andy Lutomirski Cc: Christoph Hellwig , Jens Axboe , linux-arch , Linux API , LKML , io-uring-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-arch.vger.kernel.org On Tue, Jul 21, 2020 at 07:31:02AM -0700, Andy Lutomirski wrote: > > What do you mean with "properly wired up". Do you really want to spread > > ->compat_foo methods everywhere, including read and write? I found > > in_compat_syscall() a lot small and easier to maintain than all the > > separate compat cruft. > > I was imagining using a flag. Some of the net code uses > MSG_CMSG_COMPAT for this purpose. Killing that nightmarish monster is what actually got me into looking io_uring and starting this thread.