Return-Path: Date: Wed, 22 Jul 2020 10:07:24 +0200 From: 'Christoph Hellwig' Message-ID: <20200722080724.GB26864@lst.de> References: <20200720124737.118617-1-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Bridge] get rid of the address_space override in setsockopt List-Id: Linux Ethernet Bridging List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Laight Cc: Alexei Starovoitov , "linux-sctp@vger.kernel.org" , 'Christoph Hellwig' , "linux-s390@vger.kernel.org" , "rds-devel@oss.oracle.com" , Daniel Borkmann , "dccp@vger.kernel.org" , "bridge@lists.linux-foundation.org" , "linux-afs@lists.infradead.org" , "lvs-devel@vger.kernel.org" , "coreteam@netfilter.org" , "mptcp@lists.01.org" , Alexey Kuznetsov , "linux-can@vger.kernel.org" , Jakub Kicinski , "linux-hams@vger.kernel.org" , "tipc-discussion@lists.sourceforge.net" , "linux-x25@vger.kernel.org" , Eric Dumazet , Hideaki YOSHIFUJI , "netdev@vger.kernel.org" , "linux-decnet-user@lists.sourceforge.net" , "linux-kernel@vger.kernel.org" , "linux-bluetooth@vger.kernel.org" , "netfilter-devel@vger.kernel.org" , "linux-crypto@vger.kernel.org" , "bpf@vger.kernel.org" , "linux-wpan@vger.kernel.org" , "David S. Miller" On Tue, Jul 21, 2020 at 10:26:58AM +0000, David Laight wrote: > From: Christoph Hellwig > > Sent: 20 July 2020 13:47 > > > > setsockopt is the last place in architecture-independ code that still > > uses set_fs to force the uaccess routines to operate on kernel pointers. > > > > This series adds a new sockptr_t type that can contained either a kernel > > or user pointer, and which has accessors that do the right thing, and > > then uses it for setsockopt, starting by refactoring some low-level > > helpers and moving them over to it before finally doing the main > > setsockopt method. > > Another 'gotcha' ... > > On an least some architectures (possibly only m68k) IIRC all structures > are actually passed by reference. > (This used to be true for sparc - but it may have changed in the > last 30 years.) Tough luck for ABIs wit suboptimal calling conventions. At least we can do the right thing for those that do not have the problem.