Return-Path: Date: Thu, 23 Jul 2020 16:44:55 +0200 From: 'Christoph Hellwig' Message-ID: <20200723144455.GA12280@lst.de> References: <20200723060908.50081-1-hch@lst.de> <20200723060908.50081-4-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Bridge] [PATCH 03/26] bpfilter: reject kernel addresses List-Id: Linux Ethernet Bridging List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Laight Cc: Alexei Starovoitov , "linux-sctp@vger.kernel.org" , 'Christoph Hellwig' , "linux-s390@vger.kernel.org" , "rds-devel@oss.oracle.com" , Daniel Borkmann , "dccp@vger.kernel.org" , "bridge@lists.linux-foundation.org" , "linux-afs@lists.infradead.org" , "lvs-devel@vger.kernel.org" , "coreteam@netfilter.org" , "mptcp@lists.01.org" , Alexey Kuznetsov , "linux-can@vger.kernel.org" , Jakub Kicinski , "linux-hams@vger.kernel.org" , "tipc-discussion@lists.sourceforge.net" , "linux-x25@vger.kernel.org" , Eric Dumazet , Hideaki YOSHIFUJI , "netdev@vger.kernel.org" , "linux-decnet-user@lists.sourceforge.net" , "linux-kernel@vger.kernel.org" , "linux-bluetooth@vger.kernel.org" , "netfilter-devel@vger.kernel.org" , "linux-crypto@vger.kernel.org" , "bpf@vger.kernel.org" , "linux-wpan@vger.kernel.org" , "David S. Miller" On Thu, Jul 23, 2020 at 02:42:11PM +0000, David Laight wrote: > From: Christoph Hellwig > > Sent: 23 July 2020 07:09 > > > > The bpfilter user mode helper processes the optval address using > > process_vm_readv. Don't send it kernel addresses fed under > > set_fs(KERNEL_DS) as that won't work. > > What sort of operations is the bpf filter doing on the sockopt buffers? > > Any attempts to reject some requests can be thwarted by a second > application thread modifying the buffer after the bpf filter has > checked that it allowed. > > You can't do security by reading a user buffer twice. I'm not saying that I approve of the design, but the current bpfilter design uses process_vm_readv to access the buffer, which obviously does not work with kernel buffers.