Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C4C1C433E4 for ; Fri, 24 Jul 2020 09:33:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 85CBA206D7 for ; Fri, 24 Jul 2020 09:33:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726638AbgGXJdy (ORCPT ); Fri, 24 Jul 2020 05:33:54 -0400 Received: from mx2.suse.de ([195.135.220.15]:50596 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726114AbgGXJdy (ORCPT ); Fri, 24 Jul 2020 05:33:54 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id CE107AC90; Fri, 24 Jul 2020 09:34:01 +0000 (UTC) Received: by ds.suse.cz (Postfix, from userid 10065) id 5FE53DA791; Fri, 24 Jul 2020 11:33:26 +0200 (CEST) Date: Fri, 24 Jul 2020 11:33:26 +0200 From: David Sterba To: Qu Wenruo Cc: Zygo Blaxell , dsterba@suse.cz, Qu Wenruo , linux-btrfs@vger.kernel.org Subject: Re: [PATCH 0/2] btrfs: balance root leak and runaway balance fix Message-ID: <20200724093326.GF3703@twin.jikos.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, Qu Wenruo , Zygo Blaxell , Qu Wenruo , linux-btrfs@vger.kernel.org References: <20200520065851.12689-1-wqu@suse.com> <20200522111347.GJ18421@twin.jikos.cz> <20200723215430.GC5890@hungrycats.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Fri, Jul 24, 2020 at 08:05:16AM +0800, Qu Wenruo wrote: > > > On 2020/7/24 上午5:54, Zygo Blaxell wrote: > > On Fri, May 22, 2020 at 01:13:47PM +0200, David Sterba wrote: > >> On Wed, May 20, 2020 at 02:58:49PM +0800, Qu Wenruo wrote: > >>> This patchset will fix the most wanted balance bug, runaway balance. > >>> All my fault, and all small fixes. > >> > >> Well, that happens. > >> > >> d2311e698578 ("btrfs: relocation: Delay reloc tree deletion after merge_reloc_roots") > >> > >> is the most broken patch in recent history (5.1+), there were so many > >> fixups but hopefully this is the last one. I've tagged the patches for > >> 5.1+ stable but we'll need manual backports due to the root refcount > >> changes in 5.7. > > > > The patch 1dae7e0e58b4 "btrfs: reloc: clear DEAD_RELOC_TREE bit for > > orphan roots to prevent runaway balance" does apply to 5.7 itself, but > > it is not present in 5.7.10. I've been running it in test (and even a > > few pre-prod) systems since May. > > Strange, I see no mail about merge failure nor merge success. > > I'll send the backport manually to all older branches. > > BTW, what's the proper tag for stable branch ranges? For inspiration look at subjects at https://lore.kernel.org/stable/ , something like, the version needs to be visible without looking to the patch. "[PATCH for 5.4] btrfs: ...." You can send it as a thread with various versions in case the patches differ, or use [PATCH for 5.4+].