From: Garrit Franke Date: Fri, 24 Jul 2020 16:47:38 +0000 Subject: Re: [PATCH] trivial: acpi: replace some bitshifts with BIT macro Message-Id: <20200724184738.ce10d8db0bbe138e2b24f7a6@gmail.com> List-Id: References: <20200724162050.18077-2-garritfranke@gmail.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: "Moore, Robert" Cc: "Wysocki, Rafael J" , "lenb@kernel.org" , "trivial@kernel.org" , "linux-acpi@vger.kernel.org" , "devel@acpica.org" , "kernel-janitors@vger.kernel.org" On Fri, 24 Jul 2020 16:29:14 +0000 "Moore, Robert" wrote: > Where is "BIT" defined? It is defined in multiple places (see include/vdso/bits.h for example), therefore I blatently assumed that it would be defined. I'm quite new to kernel development, and I'm learning along the way. Thank you for pointing this out. Would it make sense to copy this file to this drivers root, or is it not worth the effort? Thanks for your time Garrit