From: Bharata B Rao Date: Mon, 27 Jul 2020 03:50:06 +0000 Subject: Re: [PATCH v5 6/7] KVM: PPC: Book3S HV: move kvmppc_svm_page_out up Message-Id: <20200727034941.GG1082478@in.ibm.com> List-Id: References: <1595534844-16188-1-git-send-email-linuxram@us.ibm.com> <1595534844-16188-7-git-send-email-linuxram@us.ibm.com> In-Reply-To: <1595534844-16188-7-git-send-email-linuxram@us.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Ram Pai Cc: ldufour@linux.ibm.com, cclaudio@linux.ibm.com, kvm-ppc@vger.kernel.org, sathnaga@linux.vnet.ibm.com, aneesh.kumar@linux.ibm.com, sukadev@linux.vnet.ibm.com, linuxppc-dev@lists.ozlabs.org, bauerman@linux.ibm.com, david@gibson.dropbear.id.au On Thu, Jul 23, 2020 at 01:07:23PM -0700, Ram Pai wrote: > From: Laurent Dufour > > kvmppc_svm_page_out() will need to be called by kvmppc_uvmem_drop_pages() > so move it upper in this file. > > Furthermore it will be interesting to call this function when already > holding the kvm->arch.uvmem_lock, so prefix the original function with __ > and remove the locking in it, and introduce a wrapper which call that > function with the lock held. > > There is no functional change. > > Cc: Ram Pai > Cc: Bharata B Rao > Cc: Paul Mackerras > Signed-off-by: Ram Pai > Signed-off-by: Laurent Dufour Reviewed-by: Bharata B Rao Regards, Bharata.