From: Stefan Hajnoczi Date: Mon, 27 Jul 2020 20:02:22 +0100 Message-Id: <20200727190223.422280-3-stefanha@redhat.com> In-Reply-To: <20200727190223.422280-1-stefanha@redhat.com> References: <20200727190223.422280-1-stefanha@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [Virtio-fs] [PATCH v2 2/3] virtiofsd: add container-friendly -o sandbox=chroot option List-Id: Development discussions about virtio-fs List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: vromanso@redhat.com, rmohr@redhat.com, virtio-fs@redhat.com, mpatel@redhat.com, vgoyal@redhat.com dmlydGlvZnNkIGNhbm5vdCBydW4gaW4gYSBjb250YWluZXIgYmVjYXVzZSBDQVBfU1lTX0FETUlO IGlzIHJlcXVpcmVkIHRvCmNyZWF0ZSBuYW1lc3BhY2VzLgoKSW50cm9kdWNlIGEgd2Vha2VyIHNh bmRib3ggbW9kZSB0aGF0IGlzIHN1ZmZpY2llbnQgaW4gY29udGFpbmVyCmVudmlyb25tZW50cyBi ZWNhdXNlIHRoZSBjb250YWluZXIgcnVudGltZSBhbHJlYWR5IHNldHMgdXAgbmFtZXNwYWNlcy4K VXNlIGNocm9vdCB0byByZXN0cmljdCBwYXRoIHRyYXZlcnNhbCB0byB0aGUgc2hhcmVkIGRpcmVj dG9yeS4KCnZpcnRpb2ZzZCBsb3NlcyB0aGUgZm9sbG93aW5nOgoKMS4gTW91bnQgbmFtZXNwYWNl LiBUaGUgcHJvY2VzcyBjaHJvb3RzIHRvIHRoZSBzaGFyZWQgZGlyZWN0b3J5IGJ1dAogICBsZWF2 ZXMgdGhlIG1vdW50cyBpbiBwbGFjZS4gU2VjY29tcCByZWplY3RzIG1vdW50KDIpL3Vtb3VudCgy KQogICBzeXNjYWxscy4KCjIuIFBpZCBuYW1lc3BhY2UuIFRoaXMgc2hvdWxkIGJlIGZpbmUgYmVj YXVzZSB2aXJ0aW9mc2QgaXMgdGhlIG9ubHkKICAgcHJvY2VzcyBydW5uaW5nIGluIHRoZSBjb250 YWluZXIuCgozLiBOZXR3b3JrIG5hbWVzcGFjZS4gVGhpcyBzaG91bGQgYmUgZmluZSBiZWNhdXNl IHNlY2NvbXAgYWxyZWFkeQogICByZWplY3RzIHRoZSBjb25uZWN0KDIpIHN5c2NhbGwsIGJ1dCBh biBhZGRpdGlvbmFsIGxheWVyIG9mIHNlY3VyaXR5CiAgIGlzIGxvc3QuIENvbnRhaW5lciBydW50 aW1lLXNwZWNpZmljIG5ldHdvcmsgc2VjdXJpdHkgcG9saWNpZXMgY2FuIGJlCiAgIHVzZWQgZHJv cCBuZXR3b3JrIHRyYWZmaWMgKGV4Y2VwdCBmb3IgdGhlIHZob3N0LXVzZXIgVU5JWCBkb21haW4K ICAgc29ja2V0KS4KClNpZ25lZC1vZmYtYnk6IFN0ZWZhbiBIYWpub2N6aSA8c3RlZmFuaGFAcmVk aGF0LmNvbT4KLS0tCiB0b29scy92aXJ0aW9mc2QvaGVscGVyLmMgICAgICAgICB8ICA4ICsrKysr CiB0b29scy92aXJ0aW9mc2QvcGFzc3Rocm91Z2hfbGwuYyB8IDU3ICsrKysrKysrKysrKysrKysr KysrKysrKysrKysrKy0tCiBkb2NzL3Rvb2xzL3ZpcnRpb2ZzZC5yc3QgICAgICAgICB8IDMyICsr KysrKysrKysrKysrLS0tLQogMyBmaWxlcyBjaGFuZ2VkLCA4OCBpbnNlcnRpb25zKCspLCA5IGRl bGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL3Rvb2xzL3ZpcnRpb2ZzZC9oZWxwZXIuYyBiL3Rvb2xz L3ZpcnRpb2ZzZC9oZWxwZXIuYwppbmRleCAzMTA1YjZjMjNhLi45MWRjYjIzNjY0IDEwMDY0NAot LS0gYS90b29scy92aXJ0aW9mc2QvaGVscGVyLmMKKysrIGIvdG9vbHMvdmlydGlvZnNkL2hlbHBl ci5jCkBAIC0xNjgsNiArMTY4LDE0IEBAIHZvaWQgZnVzZV9jbWRsaW5lX2hlbHAodm9pZCkKICAg ICAgICAgICAgIiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBlbmFibGUvZGlzYWJsZSBy ZWFkaXJwbHVzXG4iCiAgICAgICAgICAgICIgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ZGVmYXVsdDogcmVhZGRpcnBsdXMgZXhjZXB0IHdpdGggIgogICAgICAgICAgICAiY2FjaGU9bm9u ZVxuIgorICAgICAgICAgICAiICAgIC1vIHNhbmRib3g9bmFtZXNwYWNlfGNocm9vdFxuIgorICAg ICAgICAgICAiICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHNhbmRib3hpbmcgbW9kZTpc biIKKyAgICAgICAgICAgIiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAtIG5hbWVzcGFj ZTogbW91bnQsIHBpZCwgYW5kIG5ldFxuIgorICAgICAgICAgICAiICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgbmFtZXNwYWNlcyB3aXRoIHBpdm90X3Jvb3QoMilcbiIKKyAgICAgICAg ICAgIiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGludG8gc2hhcmVkIGRpcmVjdG9y eVxuIgorICAgICAgICAgICAiICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIC0gY2hyb290 OiBjaHJvb3QoMikgaW50byBzaGFyZWRcbiIKKyAgICAgICAgICAgIiAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIGRpcmVjdG9yeSAodXNlIGluIGNvbnRhaW5lcnMpXG4iCisgICAgICAg ICAgICIgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZGVmYXVsdDogbmFtZXNwYWNlXG4i CiAgICAgICAgICAgICIgICAgLW8gdGltZW91dD08bnVtYmVyPiAgICAgICAgSS9PIHRpbWVvdXQg KHNlY29uZHMpXG4iCiAgICAgICAgICAgICIgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ZGVmYXVsdDogZGVwZW5kcyBvbiBjYWNoZT0gb3B0aW9uLlxuIgogICAgICAgICAgICAiICAgIC1v IHdyaXRlYmFja3xub193cml0ZWJhY2sgIGVuYWJsZS9kaXNhYmxlIHdyaXRlYmFjayBjYWNoZVxu IgpkaWZmIC0tZ2l0IGEvdG9vbHMvdmlydGlvZnNkL3Bhc3N0aHJvdWdoX2xsLmMgYi90b29scy92 aXJ0aW9mc2QvcGFzc3Rocm91Z2hfbGwuYwppbmRleCA1MGExNjRhNTk5Li5hNzg5NGMzZTdjIDEw MDY0NAotLS0gYS90b29scy92aXJ0aW9mc2QvcGFzc3Rocm91Z2hfbGwuYworKysgYi90b29scy92 aXJ0aW9mc2QvcGFzc3Rocm91Z2hfbGwuYwpAQCAtMTM3LDggKzEzNywxNCBAQCBlbnVtIHsKICAg ICBDQUNIRV9BTFdBWVMsCiB9OwogCitlbnVtIHsKKyAgICBTQU5EQk9YX05BTUVTUEFDRSwKKyAg ICBTQU5EQk9YX0NIUk9PVCwKK307CisKIHN0cnVjdCBsb19kYXRhIHsKICAgICBwdGhyZWFkX211 dGV4X3QgbXV0ZXg7CisgICAgaW50IHNhbmRib3g7CiAgICAgaW50IGRlYnVnOwogICAgIGludCB3 cml0ZWJhY2s7CiAgICAgaW50IGZsb2NrOwpAQCAtMTYyLDYgKzE2OCwxMiBAQCBzdHJ1Y3QgbG9f ZGF0YSB7CiB9OwogCiBzdGF0aWMgY29uc3Qgc3RydWN0IGZ1c2Vfb3B0IGxvX29wdHNbXSA9IHsK KyAgICB7ICJzYW5kYm94PW5hbWVzcGFjZSIsCisgICAgICBvZmZzZXRvZihzdHJ1Y3QgbG9fZGF0 YSwgc2FuZGJveCksCisgICAgICBTQU5EQk9YX05BTUVTUEFDRSB9LAorICAgIHsgInNhbmRib3g9 Y2hyb290IiwKKyAgICAgIG9mZnNldG9mKHN0cnVjdCBsb19kYXRhLCBzYW5kYm94KSwKKyAgICAg IFNBTkRCT1hfQ0hST09UIH0sCiAgICAgeyAid3JpdGViYWNrIiwgb2Zmc2V0b2Yoc3RydWN0IGxv X2RhdGEsIHdyaXRlYmFjayksIDEgfSwKICAgICB7ICJub193cml0ZWJhY2siLCBvZmZzZXRvZihz dHJ1Y3QgbG9fZGF0YSwgd3JpdGViYWNrKSwgMCB9LAogICAgIHsgInNvdXJjZT0lcyIsIG9mZnNl dG9mKHN0cnVjdCBsb19kYXRhLCBzb3VyY2UpLCAwIH0sCkBAIC0yNjY1LDYgKzI2NzcsNDEgQEAg c3RhdGljIHZvaWQgc2V0dXBfY2FwYWJpbGl0aWVzKGNoYXIgKm1vZGNhcHNfaW4pCiAgICAgcHRo cmVhZF9tdXRleF91bmxvY2soJmNhcC5tdXRleCk7CiB9CiAKKy8qCisgKiBVc2UgY2hyb290IGFz IGEgd2Vha2VyIHNhbmRib3ggZm9yIGVudmlyb25tZW50cyB3aGVyZSB0aGUgcHJvY2VzcyBpcwor ICogbGF1bmNoZWQgd2l0aG91dCBDQVBfU1lTX0FETUlOLgorICovCitzdGF0aWMgdm9pZCBzZXR1 cF9jaHJvb3Qoc3RydWN0IGxvX2RhdGEgKmxvKQoreworICAgIGxvLT5wcm9jX3NlbGZfZmQgPSBv cGVuKCIvcHJvYy9zZWxmL2ZkIiwgT19QQVRIKTsKKyAgICBpZiAobG8tPnByb2Nfc2VsZl9mZCA9 PSAtMSkgeworICAgICAgICBmdXNlX2xvZyhGVVNFX0xPR19FUlIsICJvcGVuKFwiL3Byb2Mvc2Vs Zi9mZFwiLCBPX1BBVEgpOiAlbVxuIik7CisgICAgICAgIGV4aXQoMSk7CisgICAgfQorCisgICAg LyoKKyAgICAgKiBNYWtlIHRoZSBzaGFyZWQgZGlyZWN0b3J5IHRoZSBmaWxlIHN5c3RlbSByb290 IHNvIHRoYXQgRlVTRV9PUEVOCisgICAgICogKGxvX29wZW4oKSkgY2Fubm90IGVzY2FwZSB0aGUg c2hhcmVkIGRpcmVjdG9yeSBieSBvcGVuaW5nIGEgc3ltbGluay4KKyAgICAgKgorICAgICAqIFRo ZSBjaHJvb3QoMikgc3lzY2FsbCBpcyBsYXRlciBkaXNhYmxlZCBieSBzZWNjb21wIGFuZCB0aGUK KyAgICAgKiBDQVBfU1lTX0NIUk9PVCBjYXBhYmlsaXR5IGlzIGRyb3BwZWQgc28gdGhhdCB0YW1w ZXJpbmcgd2l0aCB0aGUgY2hyb290CisgICAgICogaXMgbm90IHBvc3NpYmxlLgorICAgICAqCisg ICAgICogSG93ZXZlciwgaXQncyBzdGlsbCBwb3NzaWJsZSB0byBlc2NhcGUgdGhlIGNocm9vdCB2 aWEgbG8tPnByb2Nfc2VsZl9mZAorICAgICAqIGJ1dCB0aGF0IHJlcXVpcmVzIGZpcnN0IGdhaW5p bmcgY29udHJvbCBvZiB0aGUgcHJvY2Vzcy4KKyAgICAgKi8KKyAgICBpZiAoY2hyb290KGxvLT5z b3VyY2UpICE9IDApIHsKKyAgICAgICAgZnVzZV9sb2coRlVTRV9MT0dfRVJSLCAiY2hyb290KFwi JXNcIik6ICVtXG4iLCBsby0+c291cmNlKTsKKyAgICAgICAgZXhpdCgxKTsKKyAgICB9CisKKyAg ICAvKiBNb3ZlIGludG8gdGhlIGNocm9vdCAqLworICAgIGlmIChjaGRpcigiLyIpICE9IDApIHsK KyAgICAgICAgZnVzZV9sb2coRlVTRV9MT0dfRVJSLCAiY2hkaXIoXCIvXCIpOiAlbVxuIik7Cisg ICAgICAgIGV4aXQoMSk7CisgICAgfQorfQorCiAvKgogICogTG9jayBkb3duIHRoaXMgcHJvY2Vz cyB0byBwcmV2ZW50IGFjY2VzcyB0byBvdGhlciBwcm9jZXNzZXMgb3IgZmlsZXMgb3V0c2lkZQog ICogc291cmNlIGRpcmVjdG9yeS4gIFRoaXMgcmVkdWNlcyB0aGUgaW1wYWN0IG9mIGFyYml0cmFy eSBjb2RlIGV4ZWN1dGlvbiBidWdzLgpAQCAtMjY3Miw4ICsyNzE5LDEzIEBAIHN0YXRpYyB2b2lk IHNldHVwX2NhcGFiaWxpdGllcyhjaGFyICptb2RjYXBzX2luKQogc3RhdGljIHZvaWQgc2V0dXBf c2FuZGJveChzdHJ1Y3QgbG9fZGF0YSAqbG8sIHN0cnVjdCBmdXNlX3Nlc3Npb24gKnNlLAogICAg ICAgICAgICAgICAgICAgICAgICAgICBib29sIGVuYWJsZV9zeXNsb2cpCiB7Ci0gICAgc2V0dXBf bmFtZXNwYWNlcyhsbywgc2UpOwotICAgIHNldHVwX21vdW50cyhsby0+c291cmNlKTsKKyAgICBp ZiAobG8tPnNhbmRib3ggPT0gU0FOREJPWF9OQU1FU1BBQ0UpIHsKKyAgICAgICAgc2V0dXBfbmFt ZXNwYWNlcyhsbywgc2UpOworICAgICAgICBzZXR1cF9tb3VudHMobG8tPnNvdXJjZSk7CisgICAg fSBlbHNlIHsKKyAgICAgICAgc2V0dXBfY2hyb290KGxvKTsKKyAgICB9CisKICAgICBzZXR1cF9z ZWNjb21wKGVuYWJsZV9zeXNsb2cpOwogICAgIHNldHVwX2NhcGFiaWxpdGllcyhnX3N0cmR1cChs by0+bW9kY2FwcykpOwogfQpAQCAtMjgyMCw2ICsyODcyLDcgQEAgaW50IG1haW4oaW50IGFyZ2Ms IGNoYXIgKmFyZ3ZbXSkKICAgICBzdHJ1Y3QgZnVzZV9zZXNzaW9uICpzZTsKICAgICBzdHJ1Y3Qg ZnVzZV9jbWRsaW5lX29wdHMgb3B0czsKICAgICBzdHJ1Y3QgbG9fZGF0YSBsbyA9IHsKKyAgICAg ICAgLnNhbmRib3ggPSBTQU5EQk9YX05BTUVTUEFDRSwKICAgICAgICAgLmRlYnVnID0gMCwKICAg ICAgICAgLndyaXRlYmFjayA9IDAsCiAgICAgICAgIC5wb3NpeF9sb2NrID0gMSwKZGlmZiAtLWdp dCBhL2RvY3MvdG9vbHMvdmlydGlvZnNkLnJzdCBiL2RvY3MvdG9vbHMvdmlydGlvZnNkLnJzdApp bmRleCA4MjRlNzEzNDkxLi40MDYyOWY5NWFlIDEwMDY0NAotLS0gYS9kb2NzL3Rvb2xzL3ZpcnRp b2ZzZC5yc3QKKysrIGIvZG9jcy90b29scy92aXJ0aW9mc2QucnN0CkBAIC0xNywxMyArMTcsMjQg QEAgVGhpcyBwcm9ncmFtIGlzIGRlc2lnbmVkIHRvIHdvcmsgd2l0aCBRRU1VJ3MgYGAtLWRldmlj ZSB2aG9zdC11c2VyLWZzLXBjaWBgCiBidXQgc2hvdWxkIHdvcmsgd2l0aCBhbnkgdmlydHVhbCBt YWNoaW5lIG1vbml0b3IgKFZNTSkgdGhhdCBzdXBwb3J0cwogdmhvc3QtdXNlci4gIFNlZSB0aGUg RXhhbXBsZXMgc2VjdGlvbiBiZWxvdy4KIAotVGhpcyBwcm9ncmFtIG11c3QgYmUgcnVuIGFzIHRo ZSByb290IHVzZXIuICBVcG9uIHN0YXJ0dXAgdGhlIHByb2dyYW0gd2lsbAotc3dpdGNoIGludG8g YSBuZXcgZmlsZSBzeXN0ZW0gbmFtZXNwYWNlIHdpdGggdGhlIHNoYXJlZCBkaXJlY3RvcnkgdHJl ZSBhcyBpdHMKLXJvb3QuICBUaGlzIHByZXZlbnRzICJmaWxlIHN5c3RlbSBlc2NhcGVzIiBkdWUg dG8gc3ltbGlua3MgYW5kIG90aGVyIGZpbGUKLXN5c3RlbSBvYmplY3RzIHRoYXQgbWlnaHQgbGVh ZCB0byBmaWxlcyBvdXRzaWRlIHRoZSBzaGFyZWQgZGlyZWN0b3J5LiAgVGhlCi1wcm9ncmFtIGFs c28gc2FuZGJveGVzIGl0c2VsZiB1c2luZyBzZWNjb21wKDIpIHRvIHByZXZlbnQgcHRyYWNlKDIp IGFuZCBvdGhlcgotdmVjdG9ycyB0aGF0IGNvdWxkIGFsbG93IGFuIGF0dGFja2VyIHRvIGNvbXBy b21pc2UgdGhlIHN5c3RlbSBhZnRlciBnYWluaW5nCi1jb250cm9sIG9mIHRoZSB2aXJ0aW9mc2Qg cHJvY2Vzcy4KK1RoaXMgcHJvZ3JhbSBtdXN0IGJlIHJ1biBhcyB0aGUgcm9vdCB1c2VyLiAgVGhl IHByb2dyYW0gZHJvcHMgcHJpdmlsZWdlcyB3aGVyZQorcG9zc2libGUgZHVyaW5nIHN0YXJ0dXAg YWx0aG91Z2ggaXQgbXVzdCBiZSBhYmxlIHRvIGNyZWF0ZSBhbmQgYWNjZXNzIGZpbGVzCit3aXRo IGFueSB1aWQvZ2lkOgorCisqIFRoZSBhYmlsaXR5IHRvIGludm9rZSBzeXNjYWxscyBpcyBsaW1p dGVkIHVzaW5nIHNlY2NvbXAoMikuCisqIExpbnV4IGNhcGFiaWxpdGllcyg3KSBhcmUgZHJvcHBl ZC4KKworSW4gIm5hbWVzcGFjZSIgc2FuZGJveCBtb2RlIHRoZSBwcm9ncmFtIHN3aXRjaGVzIGlu dG8gYSBuZXcgZmlsZSBzeXN0ZW0KK25hbWVzcGFjZSBhbmQgaW52b2tlcyBwaXZvdF9yb290KDIp IHRvIG1ha2UgdGhlIHNoYXJlZCBkaXJlY3RvcnkgdHJlZSBpdHMgcm9vdC4KK0EgbmV3IHBpZCBh bmQgbmV0IG5hbWVzcGFjZSBpcyBhbHNvIGNyZWF0ZWQgdG8gaXNvbGF0ZSB0aGUgcHJvY2Vzcy4K KworSW4gImNocm9vdCIgc2FuZGJveCBtb2RlIHRoZSBwcm9ncmFtIGludm9rZXMgY2hyb290KDIp IHRvIG1ha2UgdGhlIHNoYXJlZAorZGlyZWN0b3J5IHRyZWUgaXRzIHJvb3QuIFRoaXMgbW9kZSBp cyBpbnRlbmRlZCBmb3IgY29udGFpbmVyIGVudmlyb25tZW50cyB3aGVyZQordGhlIGNvbnRhaW5l ciBydW50aW1lIGhhcyBhbHJlYWR5IHNldCB1cCB0aGUgbmFtZXNwYWNlcyBhbmQgdGhlIHByb2dy YW0gZG9lcworbm90IGhhdmUgcGVybWlzc2lvbiB0byBjcmVhdGUgbmFtZXNwYWNlcyBpdHNlbGYu CisKK0JvdGggc2FuZGJveCBtb2RlcyBwcmV2ZW50ICJmaWxlIHN5c3RlbSBlc2NhcGVzIiBkdWUg dG8gc3ltbGlua3MgYW5kIG90aGVyIGZpbGUKK3N5c3RlbSBvYmplY3RzIHRoYXQgbWlnaHQgbGVh ZCB0byBmaWxlcyBvdXRzaWRlIHRoZSBzaGFyZWQgZGlyZWN0b3J5LgogCiBPcHRpb25zCiAtLS0t LS0tCkBAIC03Miw2ICs4MywxMyBAQCBPcHRpb25zCiAgICogcmVhZGRpcnBsdXN8bm9fcmVhZGRp cnBsdXMgLQogICAgIEVuYWJsZS9kaXNhYmxlIHJlYWRkaXJwbHVzLiAgVGhlIGRlZmF1bHQgaXMg YGByZWFkZGlycGx1c2BgLgogCisgICogc2FuZGJveD1uYW1lc3BhY2V8Y2hyb290IC0KKyAgICBT YW5kYm94IG1vZGU6CisgICAgLSBuYW1lc3BhY2U6IENyZWF0ZSBtb3VudCwgcGlkLCBhbmQgbmV0 IG5hbWVzcGFjZXMgYW5kIHBpdm90X3Jvb3QoMikgaW50bworICAgIHRoZSBzaGFyZWQgZGlyZWN0 b3J5LgorICAgIC0gY2hyb290OiBjaHJvb3QoMikgaW50byBzaGFyZWQgZGlyZWN0b3J5ICh1c2Ug aW4gY29udGFpbmVycykuCisgICAgVGhlIGRlZmF1bHQgaXMgIm5hbWVzcGFjZSIuCisKICAgKiBz b3VyY2U9UEFUSCAtCiAgICAgU2hhcmUgaG9zdCBkaXJlY3RvcnkgdHJlZSBsb2NhdGVkIGF0IFBB VEguICBUaGlzIG9wdGlvbiBpcyByZXF1aXJlZC4KIAotLSAKMi4yNi4yCgo=