Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70415C433DF for ; Wed, 29 Jul 2020 00:41:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 530BE2076E for ; Wed, 29 Jul 2020 00:41:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730786AbgG2Al4 (ORCPT ); Tue, 28 Jul 2020 20:41:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45804 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730507AbgG2Al4 (ORCPT ); Tue, 28 Jul 2020 20:41:56 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4A72FC061794 for ; Tue, 28 Jul 2020 17:41:56 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 43F9A128D4784; Tue, 28 Jul 2020 17:25:10 -0700 (PDT) Date: Tue, 28 Jul 2020 17:41:54 -0700 (PDT) Message-Id: <20200728.174154.77325504094188897.davem@davemloft.net> To: xiyou.wangcong@gmail.com Cc: netdev@vger.kernel.org, syzbot+6e95a4fabf88dc217145@syzkaller.appspotmail.com, petrm@mellanox.com, jhs@mojatatu.com, jiri@resnulli.us Subject: Re: [Patch net-next] net_sched: initialize timer earlier in red_init() From: David Miller In-Reply-To: <20200725201707.16909-1-xiyou.wangcong@gmail.com> References: <20200725201707.16909-1-xiyou.wangcong@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 28 Jul 2020 17:25:10 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Cong Wang Date: Sat, 25 Jul 2020 13:17:07 -0700 > When red_init() fails, red_destroy() is called to clean up. > If the timer is not initialized yet, del_timer_sync() will > complain. So we have to move timer_setup() before any failure. > > Reported-and-tested-by: syzbot+6e95a4fabf88dc217145@syzkaller.appspotmail.com > Fixes: aee9caa03fc3 ("net: sched: sch_red: Add qevents "early_drop" and "mark"") > Cc: Petr Machata > Cc: Jamal Hadi Salim > Cc: Jiri Pirko > Signed-off-by: Cong Wang Applied, thank you.