Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1k1XRM-0007zN-Ov for mharc-grub-devel@gnu.org; Fri, 31 Jul 2020 11:59:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53402) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k1XRL-0007zC-1i for grub-devel@gnu.org; Fri, 31 Jul 2020 11:59:23 -0400 Received: from wout4-smtp.messagingengine.com ([64.147.123.20]:43875) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k1XRI-0004LB-RK for grub-devel@gnu.org; Fri, 31 Jul 2020 11:59:22 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 5340CF67; Fri, 31 Jul 2020 11:59:18 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Fri, 31 Jul 2020 11:59:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pks.im; h=date :from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm1; bh=rLs2qkyHP+LN9GNxtfmD7wOiaeR mFoy0jQpv1WIvujA=; b=O9EiouwmcbPV6ybz912p7TkFpE9eG/Ena68TnxsJY2O sYiHZKX49lt+lX+ryYdvLaC7a+NdUEoGQ1mnFsC9Wz62atbfGBIVWEWrHTDMEyWU 4Z8rNv3z8B5kGOyticKhF+8fnBdPBix0UVdAEsJYdroVLxhWzmtHWAojwAoT5/Dy ek0QmFrL4JtnPS+cUIbX3G+hxNDEel8w0C5XL1gVuZWG2yBqJws40026tFGoRs0f vXpP/y8gjYgTNWZ6C4/Y/iAfeV9MCQ6VT7PvJz2cIUnQ1kdWN6WVdlcBskSRQyhB ryoltErNh3N/wRtQQ5bk7T0UqwCIE7ovHYMnBPXQC1A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=rLs2qk yHP+LN9GNxtfmD7wOiaeRmFoy0jQpv1WIvujA=; b=ouXg0fcedBkl2wmPYUKUfY tdYE07x/GG9f7rldxDAvX4TYBKdZ9CV63C/NrKJXryczZrjmnZlv128xIl9AURwj O3OjcO8KsTpB0RO9XrWXKl/J1xihHO3vcEkilCpw3/ioH57wD4Wt2sG7UUHIexp2 Q5ZBJGNeRUDNOAWq81b7aM0Wy+VHJkoJzOgdIEbUGidJ9vl1OiC0tBOSsrLHM8x+ 8g7hUwlEIn9oNVwZ/IRMSSeIXLMBSvzgCwc+UspnNnYIKo5rZf+FbIbwRbM4embv OiDv7vj1YOYljDgLRkLO0dTYIzgqp7GwMaE2D0I7mOTYJ04n+vcM3Fcuk+c59PIQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrieekgdeliecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggujgesghdtreertddtvdenucfhrhhomheprfgrthhrihgt khcuufhtvghinhhhrghrughtuceophhssehpkhhsrdhimheqnecuggftrfgrthhtvghrnh epheeghfdtfeeuffehkefgffduleffjedthfdvjeektdfhhedvlefgtefgvdettdfhnecu kfhppeejjedrudekfedrgedurddtnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrg hmpehmrghilhhfrhhomhepphhssehpkhhsrdhimh X-ME-Proxy: Received: from vm-mail.pks.im (x4db72900.dyn.telefonica.de [77.183.41.0]) by mail.messagingengine.com (Postfix) with ESMTPA id 9670530600B7; Fri, 31 Jul 2020 11:59:16 -0400 (EDT) Received: from localhost (tanuki [10.192.0.23]) by vm-mail.pks.im (OpenSMTPD) with ESMTPSA id d06c926a (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Fri, 31 Jul 2020 15:59:15 +0000 (UTC) Date: Fri, 31 Jul 2020 17:59:26 +0200 From: Patrick Steinhardt To: Glenn Washburn Cc: grub-devel@gnu.org, Daniel Kiper Subject: Re: [CRYPTO-LUKS v1 00/19] Fixes and improvements for cryptodisks+luks2 and a few other things. Message-ID: <20200731155926.GC11731@tanuki.pks.im> References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="i7F3eY7HS/tUJxUd" Content-Disposition: inline In-Reply-To: Received-SPF: pass client-ip=64.147.123.20; envelope-from=ps@pks.im; helo=wout4-smtp.messagingengine.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/31 11:34:12 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 31 Jul 2020 15:59:23 -0000 --i7F3eY7HS/tUJxUd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Jul 31, 2020 at 07:01:41AM -0500, Glenn Washburn wrote: > I've changed the name of the patch series to make it more self-explanatory, but > still incremented the version number. All of Patrick's suggestions have been > added in. I've added 2 new patches, one suggested by Patrick for rename > cryptodisk's offset member to offset_sectors. And another to rename 'disk' to > 'source' where appropriate in luks2.c. Thanks for adressing my feedback! I'm not authoritative in this project in any way, but I guess you'll have an easier time to get things merged if you split this up into multiple patch series as there's unrelated things you're doing here. E.g. something like the following might work and make the review load a bit more manageable. Font fix. > configure: Add Ubuntu dejavu font path. Profcs changes: > loopback: Add procfs entry 'loopbacks' to output configured loopback > devices. > cryptodisk,luks2: Add header line to procfs entry and crypto and > source device names. Cryptodisk related changes independent of LUKS: > cryptodisk: Fix cipher IV mode 'plain64' always being set as 'plain'. > cryptodisk: Incorrect calculation of start sector for grub_disk_read > in grub_cryptodisk_read. > cryptodisk: Add more verbosity when reading/writing cryptodisks. > cryptodisk: Rename offset in grub_cryptodisk_t to offset_sectors to > improve readability. > cryptodisk: Add a couple comments noting the usage of a couple fields > in grub_cryptodisk_t as is done for grub_disk_t. > cryptodisk: Unregister cryptomount command when removing module. > cryptodisk: Properly handle non-512 byte sized sectors. > cryptodisk: Rename total_length field in grub_cryptodisk_t to > total_sectors. LUKS-specfic changes: > luks2: Rename source disk variabled named 'disk' to 'source' as in > luks.c. > luks2: Fix use of incorrect index and some error messages. > luks2: Ensure that bit fields of grub_luks2_digest_t in > luks2_parse_digest are initialized before returning. > luks2: Add support for LUKS2 in (proc)/luks_script > luks2: grub_cryptodisk_t->total_length is the max number of device > native sectors. > cryptodisk,luks: Allow special processing for comparing UUIDs. fs-specific changes: > fs: Fix block lists not being able to address to end of disk > sometimes. > fs: Allow number of blocks in block list to be optional, where length > will be defaulted to the length of the device. Patrick --i7F3eY7HS/tUJxUd Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEF9hrgiFbCdvenl/rVbJhu7ckPpQFAl8kP90ACgkQVbJhu7ck PpTy9w//Y7c2eOCBHg0ID6dgMoFqzkf+7ssv98/zUnTKUsFIC6QCA91ryj/v5G3Y t9wpOBjzA+bU6o87Ed3bjBogwCq59A+HN2RYFiE8KlRsIbvig/pLvNwKwGgKz8KH 4upYUgjaFAQkf0H8mt/Xot798srY2NmM96kI+zHx3lEb5JgxwD4QB5v3r0WSZY3a P0v/gsEDY2JlkaaNfTYJooxKSHlk+8RW4zRSKhK0AvM9862VHujz9w3lpbmTXFgU pbRIqnqtN2bCz7HFMrWchzxfzX+5ywo+FwCPd9Xkd4Fk8H/P2lxYuG4jhrL0pVUH np2q3ckIaLCLqkZCNXx4eaAzgk21mO6UZjOwW4kYkysxRngNewkc5Q8ePdaw24fZ L3DGpFgseZvc0efK0D68EYK9QvaOLVya4gONsOdYv0fFdZgjMZVg0LUZZS7d5pD9 u3Jj+4XiuX8s9EzBOvnzfMhtrFFCX66tQ71uD+s10rp+uIncIfr0/A6os8BcCPL1 8JyyvJF6FBmLkzNBG/EBanqK8091sJ7Z+rjTuBYnGIOOyQFMLlflhpCSDCOnAoQ1 3BNUWiSO4adhb0z07ciEXhqJCuJKN3X6Py+egIWpqASliM25LXAEGagQu0x3BGd5 cPicL8OaxDkfaEUu5CksU1nvCuv2xfYeqrR6RBANPrdPsQKLTIE= =eSd0 -----END PGP SIGNATURE----- --i7F3eY7HS/tUJxUd--