Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1k1brN-0005jY-UK for mharc-qemu-trivial@gnu.org; Fri, 31 Jul 2020 16:42:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60328) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k1brM-0005iz-Ht for qemu-trivial@nongnu.org; Fri, 31 Jul 2020 16:42:32 -0400 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:24581 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1k1brK-0006L0-Db for qemu-trivial@nongnu.org; Fri, 31 Jul 2020 16:42:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1596228146; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UESLcMXNNYX8BjZd7vrqMNyETHH3fBLnnwqiaMWQcl4=; b=ad8NHyqS43EvNeAXI+mLEoAYl/U/WY47AK8+BRHvNXrJhMCiEITUtggUJwXgX/7jxR9otz KCUB8mb0q7VNWJLpL8YSoig7mDruVBX9T4tXaWy+DUrpfJzpsilRuGP5jQfh48NdbB9lRt VoLK2UCPg0e/ew/S9YkvKE4ZYiP7r5I= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-385-xHZRB3I2PE6GIc6vyQ1jVA-1; Fri, 31 Jul 2020 16:42:24 -0400 X-MC-Unique: xHZRB3I2PE6GIc6vyQ1jVA-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 90C2A101C8A0; Fri, 31 Jul 2020 20:42:23 +0000 (UTC) Received: from localhost (ovpn-120-33.rdu2.redhat.com [10.10.120.33]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2F62D6FEEB; Fri, 31 Jul 2020 20:42:20 +0000 (UTC) Date: Fri, 31 Jul 2020 16:42:19 -0400 From: Eduardo Habkost To: Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= Cc: qemu-devel@nongnu.org, qemu-trivial@nongnu.org, Richard Henderson , "Michael S. Tsirkin" , Marcel Apfelbaum , Paolo Bonzini , Richard Henderson Subject: Re: [PATCH] hw/i386/vmport: Drop superfluous parenthesis around function typedef Message-ID: <20200731204219.GK225270@habkost.net> References: <20200505142836.16903-1-philmd@redhat.com> <303faba8-851f-a0da-4df3-0d57ffd1ff14@redhat.com> MIME-Version: 1.0 In-Reply-To: <303faba8-851f-a0da-4df3-0d57ffd1ff14@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Content-Disposition: inline Received-SPF: pass client-ip=207.211.31.81; envelope-from=ehabkost@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/31 08:55:49 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -40 X-Spam_score: -4.1 X-Spam_bar: ---- X-Spam_report: (-4.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 31 Jul 2020 20:42:32 -0000 On Wed, Jun 03, 2020 at 07:04:26AM +0200, Philippe Mathieu-Daudé wrote: > On 5/5/20 4:28 PM, Philippe Mathieu-Daudé wrote: > > Drop superfluous parenthesis around VMPortReadFunc typedef > > (added in d67f679d99, missed to remove when moved in e595112985). > > > > Suggested-by: Richard Henderson > > Signed-off-by: Philippe Mathieu-Daudé > > --- > > hw/i386/vmport.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/hw/i386/vmport.h b/hw/i386/vmport.h > > index 47eda7a22b..a6624e3045 100644 > > --- a/hw/i386/vmport.h > > +++ b/hw/i386/vmport.h > > @@ -27,7 +27,7 @@ > > > > #define TYPE_VMPORT "vmport" > > > > -typedef uint32_t (VMPortReadFunc)(void *opaque, uint32_t address); > > +typedef uint32_t VMPortReadFunc(void *opaque, uint32_t address); > > > > void vmport_register(unsigned char command, VMPortReadFunc *func, void *opaque); > > > > > > ping? Queued for 5.2. Sorry for missing it. -- Eduardo