Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3031C433E0 for ; Mon, 3 Aug 2020 15:00:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 882AB20775 for ; Mon, 3 Aug 2020 15:00:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727092AbgHCPAy (ORCPT ); Mon, 3 Aug 2020 11:00:54 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:40382 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726189AbgHCPAy (ORCPT ); Mon, 3 Aug 2020 11:00:54 -0400 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1k2bxL-0083TB-CH; Mon, 03 Aug 2020 17:00:51 +0200 Date: Mon, 3 Aug 2020 17:00:51 +0200 From: Andrew Lunn To: "Madalin Bucur (OSS)" Cc: Russell King - ARM Linux admin , Vikas Singh , "f.fainelli@gmail.com" , "hkallweit1@gmail.com" , "netdev@vger.kernel.org" , "Calvin Johnson (OSS)" , kuldip dwivedi , Vikas Singh Subject: Re: [PATCH 2/2] net: phy: Associate device node with fixed PHY Message-ID: <20200803150051.GA1919070@lunn.ch> References: <20200731153119.GJ1712415@lunn.ch> <20200801094132.GH1551@shell.armlinux.org.uk> <20200801151107.GK1712415@lunn.ch> <20200803090716.GL1551@shell.armlinux.org.uk> <20200803125742.GK1862409@lunn.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Aug 03, 2020 at 02:33:56PM +0000, Madalin Bucur (OSS) wrote: > > -----Original Message----- > > From: Andrew Lunn > > Sent: 03 August 2020 15:58 > > To: Madalin Bucur (OSS) > > Cc: Russell King - ARM Linux admin ; Vikas Singh > > ; f.fainelli@gmail.com; hkallweit1@gmail.com; > > netdev@vger.kernel.org; Calvin Johnson (OSS) ; > > kuldip dwivedi ; Vikas Singh > > > > Subject: Re: [PATCH 2/2] net: phy: Associate device node with fixed PHY > > > > > I see you agree that there were and there will be many changes for a > > while, > > > It's not a complaint, I know hot it works, it's just a decision based on > > > required effort vs features offered vs user requirements. Lately it's > > been > > > time consuming to try to fix things in this area. > > > > So the conclusion to all this that you are unwilling to use the > > correct API for this, which would be phylink, and the SFP code. So: > > > > NACK > > > > Andrew > > You've rejected a generic change - ACPI support for fixed link. > The discussion above is just an example of how it could have been (mis-)used. > Are you rejecting the general case or just the particular one? So far, nobody has corrected me that the MAC is not connected to an SFP socket. So i see two sorts of abuse going on here: 1) Using a fixed link with a hack to allow 10G. phylink allows 10G fixed links without an hacks. 2) Using a fixed link when not even appropriate since phylink should be used to control the SFP. Now, you can do whatever you want in your Vendor Crap tree. But there is no reason mainline should help you support your vendor crap tree. To make progress here, you need to add an in tree user of this generic change. And since that means an ACPI user, you need to follow what has been set out in the other thread. You need an ACPI maintainer to ACK it. And to get an ACPI maintainer to ACK it, you need a specification, and proof it is being used. And to get my ACK, it needs to be valid use of it as well. Andrew