Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 620E9C433DF for ; Tue, 4 Aug 2020 09:21:30 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 55F192086A for ; Tue, 4 Aug 2020 09:21:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=citrix.com header.i=@citrix.com header.b="UEg12rMb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 55F192086A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=citrix.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2t7v-0001hV-DM; Tue, 04 Aug 2020 09:20:55 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k2t7u-0001hQ-4U for xen-devel@lists.xenproject.org; Tue, 04 Aug 2020 09:20:54 +0000 X-Inumbo-ID: caf9ecc7-d633-11ea-913d-bc764e2007e4 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id caf9ecc7-d633-11ea-913d-bc764e2007e4; Tue, 04 Aug 2020 09:20:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1596532853; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=0YqTm8Wb4K9XKQSC3g7togEL7aTIVm8AWDi9Gqx1kAM=; b=UEg12rMbo32BIeHedpZGvJ3+JQcQsmhQx1KWumEQykjzWCevLq2an2zT CXSG5Lh4fLdz1qby6eFyKywcsE463UM3zimECjqLQ+0Ynk+aC9opw2oni jbaqyiTuVx7ug66sUOHOapPvkVJH0OYz1xgnfcdzfyQqs3yVFCfe7WkPV w=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: mkDWYMpTe+0YcZjSXoM1iQw9PH9oKlyIwnALZB6VQtHcM6CZaDUcTXIHCRsqEG3ZKKltbNlDTM 1rTHpAFUWv/H+304+vK+T+YFCHdmDGPS44Eapvr+bZuzWNSlB4Mm62nXaSGKDaD3Th6YcxTHrJ E//VA8AsDwSQTMd5EbmQmj29guus6D0GiOfFIEakEO6NvXPqzZcYDEZxDyfPSUdTgTUey6NAeU eahzJ+HREgk6DNOHwvldFqoPAPJ2MCKgBPeoQwrb+mx+qb6q1U0iwX+YLM8Zh9lLmvGYMuLU68 skI= X-SBRS: 3.7 X-MesageID: 23979240 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.75,433,1589256000"; d="scan'208";a="23979240" Date: Tue, 4 Aug 2020 10:20:48 +0100 From: Anthony PERARD To: Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= Subject: Re: [PATCH-for-5.1 v2 1/1] accel/xen: Fix xen_enabled() behavior on target-agnostic objects Message-ID: <20200804092048.GE2866@perard.uk.xensource.com> References: <20200804074930.13104-1-philmd@redhat.com> <20200804074930.13104-2-philmd@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200804074930.13104-2-philmd@redhat.com> X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Stefano Stabellini , Paul Durrant , Paul Durrant , qemu-devel@nongnu.org, Paolo Bonzini , xen-devel@lists.xenproject.org Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On Tue, Aug 04, 2020 at 09:49:30AM +0200, Philippe Mathieu-Daudé wrote: > CONFIG_XEN is generated by configure and stored in "config-target.h", > which is (obviously) only include for target-specific objects. > This is a problem for target-agnostic objects as CONFIG_XEN is never > defined and xen_enabled() is always inlined as 'false'. > > Fix by following the KVM schema, defining CONFIG_XEN_IS_POSSIBLE > when we don't know to force the call of the non-inlined function, > returning the xen_allowed boolean. > > Fixes: da278d58a092 ("accel: Move Xen accelerator code under accel/xen/") > Reported-by: Paul Durrant > Suggested-by: Peter Maydell > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Anthony PERARD This time, I've also check that build all targets works... I'll prepare the pull request right away. Thank you, -- Anthony PERARD