Date: Tue, 11 Aug 2020 13:44:29 -0400 From: Vivek Goyal Message-ID: <20200811174429.GA497326@redhat.com> References: <20200807195526.426056-1-vgoyal@redhat.com> <20200807195526.426056-14-vgoyal@redhat.com> <20200810220655.GC2079@dread.disaster.area> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200810220655.GC2079@dread.disaster.area> Subject: Re: [Virtio-fs] [PATCH v2 13/20] fuse, dax: Implement dax read/write operations List-Id: Development discussions about virtio-fs List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Dave Chinner Cc: miklos@szeredi.hu, linux-kernel@vger.kernel.org, virtio-fs@redhat.com, linux-fsdevel@vger.kernel.org On Tue, Aug 11, 2020 at 08:06:55AM +1000, Dave Chinner wrote: > On Fri, Aug 07, 2020 at 03:55:19PM -0400, Vivek Goyal wrote: > > This patch implements basic DAX support. mmap() is not implemented > > yet and will come in later patches. This patch looks into implemeting > > read/write. > > .... > > > +static int iomap_begin_setup_new_mapping(struct inode *inode, loff_t pos, > > + loff_t length, unsigned flags, > > + struct iomap *iomap) > > please doin't use the iomap_* namespace even for static functions in > filesystem code. This really doesn't have anything to do with iomap > except that whatever fuse sets up is used to fill an iomap. > i.e. fuse_setup_new_dax_mapping() would be far more appropriate > name. > > > +static int iomap_begin_upgrade_mapping(struct inode *inode, loff_t pos, > > + loff_t length, unsigned flags, > > + struct iomap *iomap) > > ditto: fuse_upgrade_dax_mapping(). > Hi Dave, Will rename these functions as you suggested. Vivek