From: Tom Rini Date: Wed, 12 Aug 2020 08:00:14 -0400 Subject: [PATCH] Makefile: fix annoying sunxi hack message In-Reply-To: <47ac28ea-3dce-5e3f-3bfd-a03c8329e78d@monstr.eu> References: <20200811151954.78536-1-linux@fw-web.de> <20200811153254.GY20605@bill-the-cat> <20200812114151.GD20605@bill-the-cat> <47ac28ea-3dce-5e3f-3bfd-a03c8329e78d@monstr.eu> Message-ID: <20200812120014.GE20605@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wed, Aug 12, 2020 at 01:48:33PM +0200, Michal Simek wrote: > > > On 12. 08. 20 13:41, Tom Rini wrote: > > On Wed, Aug 12, 2020 at 09:59:15AM +0200, Michal Simek wrote: > >> ?t 11. 8. 2020 v 17:33 odes?latel Tom Rini napsal: > >>> > >>> On Tue, Aug 11, 2020 at 05:19:54PM +0200, Frank Wunderlich wrote: > >>> > >>>> From: Frank Wunderlich > >>>> > >>>> every compilation shows this error > >>>> > >>>> Hack for sunxi which doesn't have a proper binman definition for > >>>> 64-bit boards > >>>> > >>>> not only for sunxi-boards/arm64 > >>>> > >>>> fix this by changing to real comments > >>>> > >>>> Fixes: 9f55ee259d0c ("Makefile: sunxi: Don't use binman to build ATF image") > >>>> Signed-off-by: Frank Wunderlich > >>>> --- > >>>> Makefile | 4 ++-- > >>>> 1 file changed, 2 insertions(+), 2 deletions(-) > >>>> > >>>> diff --git a/Makefile b/Makefile > >>>> index 4483a9bc8a..75c2987405 100644 > >>>> --- a/Makefile > >>>> +++ b/Makefile > >>>> @@ -1024,8 +1024,8 @@ PHONY += inputs > >>>> inputs: $(INPUTS-y) > >>>> > >>>> all: .binman_stamp inputs > >>>> - # Hack for sunxi which doesn't have a proper binman definition for > >>>> - # 64-bit boards > >>>> +# Hack for sunxi which doesn't have a proper binman definition for > >>>> +# 64-bit boards > >>>> ifneq ($(CONFIG_ARCH_SUNXI)$(CONFIG_ARM64),yy) > >>>> ifeq ($(CONFIG_BINMAN),y) > >>>> $(call if_changed,binman) > >>> > >>> Um, what environment is this failing on? Thanks! > >> > >> I also see this message when I build stuff for zynqmp. > > > > Interesting, are you also on make 4.2 ? > > I am on 4.1. Ugh. I'll apply the patch shortly as clearly we need it. But I don't see why it's failing in some places and not others, which is worrying. -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: