Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43167C433DF for ; Thu, 13 Aug 2020 02:03:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 24E9E20675 for ; Thu, 13 Aug 2020 02:03:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726526AbgHMCDH (ORCPT ); Wed, 12 Aug 2020 22:03:07 -0400 Received: from correo.us.es ([193.147.175.20]:60554 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726406AbgHMCDH (ORCPT ); Wed, 12 Aug 2020 22:03:07 -0400 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id 8DF70DA8E0 for ; Thu, 13 Aug 2020 04:03:06 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 7F3CDDA704 for ; Thu, 13 Aug 2020 04:03:06 +0200 (CEST) Received: by antivirus1-rhel7.int (Postfix, from userid 99) id 74D88DA722; Thu, 13 Aug 2020 04:03:06 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 6955CDA704; Thu, 13 Aug 2020 04:03:04 +0200 (CEST) Received: from 192.168.1.97 (192.168.1.97) by antivirus1-rhel7.int (F-Secure/fsigk_smtp/550/antivirus1-rhel7.int); Thu, 13 Aug 2020 04:03:04 +0200 (CEST) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/antivirus1-rhel7.int) Received: from us.es (246.pool85-48-185.static.orange.es [85.48.185.246]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: 1984lsi) by entrada.int (Postfix) with ESMTPSA id F18E642EE38E; Thu, 13 Aug 2020 04:03:03 +0200 (CEST) Date: Thu, 13 Aug 2020 04:03:01 +0200 X-SMTPAUTHUS: auth mail.us.es From: Pablo Neira Ayuso To: Phil Sutter Cc: netfilter-devel@vger.kernel.org Subject: Re: [iptables PATCH v2 2/2] tests: shell: Merge and extend return codes test Message-ID: <20200813020301.GB3104@salvia> References: <20200807120214.3762-1-phil@nwl.cc> <20200807120214.3762-2-phil@nwl.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200807120214.3762-2-phil@nwl.cc> User-Agent: Mutt/1.10.1 (2018-07-13) X-Virus-Scanned: ClamAV using ClamSMTP Sender: netfilter-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org On Fri, Aug 07, 2020 at 02:02:14PM +0200, Phil Sutter wrote: > Merge scripts for iptables and ip6tables, they were widely identical. > Also extend the test by one check (removing a non-existent rule with > valid chain and target) and quote the error messages where differences > are deliberately ignored. > > Signed-off-by: Phil Sutter Acked-by: Pablo Neira Ayuso