From: Christoph Hellwig Subject: Re: [RESEND PATCH] nvme: explicitly use normal NVMe error handling when appropriate Date: Thu, 13 Aug 2020 16:36:23 +0100 Message-ID: <20200813153623.GA30905@infradead.org> References: <20200806184057.GA27858@redhat.com> <20200806191943.GA27868@redhat.com> <6B826235-C504-4621-B8F7-34475B200979@netapp.com> <20200807000755.GA28957@redhat.com> <510f5aff-0437-b1ce-f7ab-c812edbea880@grimberg.me> <20200807045015.GA29737@redhat.com> <20200810143620.GA19127@redhat.com> <20200810172209.GA19535@redhat.com> <20200813144811.GA5452@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20200813144811.GA5452@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com Content-Disposition: inline To: Mike Snitzer Cc: Sagi Grimberg , Ewan Milne , Christoph Hellwig , dm-devel@redhat.com, linux-nvme@lists.infradead.org, Chao Leng , Keith Busch , "Meneghini, John" List-Id: dm-devel.ids On Thu, Aug 13, 2020 at 10:48:11AM -0400, Mike Snitzer wrote: > Commit 764e9332098c0 ("nvme-multipath: do not reset on unknown > status"), among other things, fixed NVME_SC_CMD_INTERRUPTED error > handling by changing multipathing's nvme_failover_req() to short-circuit > path failover and then fallback to NVMe's normal error handling (which > takes care of NVME_SC_CMD_INTERRUPTED). > > This detour through native NVMe multipathing code is unwelcome because > it prevents NVMe core from handling NVME_SC_CMD_INTERRUPTED independent > of any multipathing concerns. > > Introduce nvme_status_needs_local_error_handling() to prioritize > non-failover retry, when appropriate, in terms of normal NVMe error > handling. nvme_status_needs_local_error_handling() will naturely evolve > to include handling of any other errors that normal error handling must > be used for. > > nvme_failover_req()'s ability to fallback to normal NVMe error handling > has been preserved because it may be useful for future NVME_SC that > nvme_status_needs_local_error_handling() hasn't been trained for yet. > > Signed-off-by: Mike Snitzer I don't see how this would change anything. nvme_failover_req simply retuns false for NVME_SC_CMD_INTERRUPTED, so your change is a no-op.