From: Benjamin Marzinski Subject: Re: [PATCH v2 46/54] libmultipath: path_discover(): explain pathinfo flags Date: Thu, 13 Aug 2020 17:58:11 -0500 Message-ID: <20200813225811.GA19233@octiron.msp.redhat.com> References: <20200812113429.26314-1-mwilck@suse.com> <20200812113429.26314-3-mwilck@suse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20200812113429.26314-3-mwilck@suse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com Content-Disposition: inline To: mwilck@suse.com Cc: dm-devel@redhat.com List-Id: dm-devel.ids On Wed, Aug 12, 2020 at 01:34:29PM +0200, mwilck@suse.com wrote: > From: Martin Wilck > > Add a comment explaining why we use different flags for "new" and > existing paths. > Reviewed-by: Benjamin Marzinski > Signed-off-by: Martin Wilck > --- > libmultipath/discovery.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/libmultipath/discovery.c b/libmultipath/discovery.c > index 5f4ebf0..64d3473 100644 > --- a/libmultipath/discovery.c > +++ b/libmultipath/discovery.c > @@ -137,6 +137,11 @@ path_discover (vector pathvec, struct config * conf, > udevice, flag | DI_BLACKLIST, > NULL); > else > + /* > + * Don't use DI_BLACKLIST on paths already in pathvec. We rely > + * on the caller to pre-populate the pathvec with valid paths > + * only. > + */ > return pathinfo(pp, conf, flag); > } > > -- > 2.28.0