From: Benjamin Marzinski Subject: Re: [PATCH v2 64/74] libmultipath: orphan_paths(): avoid BUG message Date: Thu, 13 Aug 2020 21:26:10 -0500 Message-ID: <20200814022610.GD19233@octiron.msp.redhat.com> References: <20200812113511.26469-1-mwilck@suse.com> <20200812113511.26469-6-mwilck@suse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20200812113511.26469-6-mwilck@suse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com Content-Disposition: inline To: mwilck@suse.com Cc: dm-devel@redhat.com List-Id: dm-devel.ids On Wed, Aug 12, 2020 at 01:35:08PM +0200, mwilck@suse.com wrote: > From: Martin Wilck > > Since c44d769, we print a BUG message when we orphan a path that > holds the mpp->hwe pointer. But if this called via orphan_paths(), > this is expected and we shouldn't warn. > Reviewed-by: Benjamin Marzinski > Fixes: c44d769 ("libmultipath: warn if freeing path that holds mpp->hwe") > Signed-off-by: Martin Wilck > --- > libmultipath/structs_vec.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libmultipath/structs_vec.c b/libmultipath/structs_vec.c > index ba3165a..b644d3f 100644 > --- a/libmultipath/structs_vec.c > +++ b/libmultipath/structs_vec.c > @@ -124,6 +124,8 @@ void orphan_paths(vector pathvec, struct multipath *mpp, const char *reason) > int i; > struct path * pp; > > + /* Avoid BUG message from orphan_path() */ > + mpp->hwe = NULL; > vector_foreach_slot (pathvec, pp, i) { > if (pp->mpp == mpp) { > if (pp->initialized == INIT_REMOVED) { > -- > 2.28.0