From: Christoph Hellwig Subject: Re: [RESEND PATCH] nvme: explicitly use normal NVMe error handling when appropriate Date: Fri, 14 Aug 2020 07:55:59 +0100 Message-ID: <20200814065559.GA29917@infradead.org> References: <510f5aff-0437-b1ce-f7ab-c812edbea880@grimberg.me> <20200807045015.GA29737@redhat.com> <20200810143620.GA19127@redhat.com> <20200810172209.GA19535@redhat.com> <20200813144811.GA5452@redhat.com> <20200813153623.GA30905@infradead.org> <20200813174704.GA6137@redhat.com> <20200813184349.GA8191@infradead.org> <96aff2d0-5907-f5c9-9164-8fea0d030d95@grimberg.me> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <96aff2d0-5907-f5c9-9164-8fea0d030d95@grimberg.me> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com Content-Disposition: inline To: Sagi Grimberg Cc: Mike Snitzer , linux-nvme@lists.infradead.org, Christoph Hellwig , dm-devel@redhat.com, Ewan Milne , Chao Leng , Keith Busch , "Meneghini, John" List-Id: dm-devel.ids On Thu, Aug 13, 2020 at 11:53:14PM -0700, Sagi Grimberg wrote: > > + switch (nvme_req_disposition(req)) { > > + case COMPLETE: > > + nvme_complete_req(req); > > nvme_complete_rq calling nvme_complete_req... Maybe call it > __nvme_complete_rq instead? That's what I had first, but it felt so strangely out of place next to the other nvme_*_req calls.. Maybe nvme_complete_rq needs to be renamed - what about nvme_req_done? > Maybe call nvme_req_disposition again locally here to not carry > the is_ana_status. But not a biggy.. That means it would have to become non-static in scope, limiting inlining possibilities, etc.