Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 102F8C433DF for ; Sat, 15 Aug 2020 21:43:40 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DF4B523B24 for ; Sat, 15 Aug 2020 21:43:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DF4B523B24 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ens-lyon.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k73xa-0001QT-R1; Sat, 15 Aug 2020 21:43:30 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k73xZ-0001Ps-Ra for xen-devel@lists.xenproject.org; Sat, 15 Aug 2020 21:43:29 +0000 X-Inumbo-ID: dd007171-d210-4b69-98ea-e0c516208e1c Received: from hera.aquilenet.fr (unknown [185.233.100.1]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id dd007171-d210-4b69-98ea-e0c516208e1c; Sat, 15 Aug 2020 21:43:23 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 14AE511457; Sat, 15 Aug 2020 23:43:23 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0t9WTyfwBkGy; Sat, 15 Aug 2020 23:43:22 +0200 (CEST) Received: from function.home (2a01cb008800c5009eb6d0fffe88c3c7.ipv6.abo.wanadoo.fr [IPv6:2a01:cb00:8800:c500:9eb6:d0ff:fe88:c3c7]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 41BFB2E70; Sat, 15 Aug 2020 23:43:22 +0200 (CEST) Received: from samy by function.home with local (Exim 4.94) (envelope-from ) id 1k73xR-001iMT-Gi; Sat, 15 Aug 2020 23:43:21 +0200 Date: Sat, 15 Aug 2020 23:43:21 +0200 From: Samuel Thibault To: Juergen Gross Cc: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org Subject: Re: [PATCH] mini-os: fix do_map_frames() for pvh Message-ID: <20200815214321.qp46x46ucqlh6mp6@function> Mail-Followup-To: Samuel Thibault , Juergen Gross , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org References: <20200815111257.29302-1-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200815111257.29302-1-jgross@suse.com> Organization: I am not organized User-Agent: NeoMutt/20170609 (1.8.3) X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Juergen Gross, le sam. 15 août 2020 13:12:57 +0200, a ecrit: > In case ov PVH dom_map_frames() is missing to increment the virtual > address. This leads to writing only the first page table entry multiple > times. > > Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault > --- > arch/x86/mm.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/x86/mm.c b/arch/x86/mm.c > index ea58444..8ba14a5 100644 > --- a/arch/x86/mm.c > +++ b/arch/x86/mm.c > @@ -695,6 +695,7 @@ int do_map_frames(unsigned long va, > pgt[l1_table_offset(va)] = (pgentry_t) > (((mfns[done * stride] + done * incr) << PAGE_SHIFT) | prot); > done++; > + va += PAGE_SIZE; > #endif > } > > -- > 2.26.2 > -- Samuel j'etais en train de nettoyer ma souris et le coup est parti... -+- s sur #ens-mim - et en plus c vrai... -+-