From: Wolfgang Denk Date: Tue, 18 Aug 2020 12:31:32 +0200 Subject: [PATCH v4 1/9] CONFIG_NR_DRAM_BANKS: Remove unreferenced code as its always defined In-Reply-To: <20200813054800.469284-2-sr@denx.de> References: <20200813054800.469284-1-sr@denx.de> <20200813054800.469284-2-sr@denx.de> Message-ID: <20200818103132.690B1242DD7@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Stefan Roese, In message <20200813054800.469284-2-sr@denx.de> you wrote: > Since commit 86cf1c82850f ("configs: Migrate CONFIG_NR_DRAM_BANKS") & > commit 999a772d9f24 ("Kconfig: Migrate CONFIG_NR_DRAM_BANKS"), > CONFIG_NR_DRAM_BANKS is always defined with a value (4 is default). Has there been any evaluation about the impact this change had on both text and data sizes of the resulting U-Boot image? Especially the default value of 4 makes no sense to me - whiy is this not 1? > It makes no sense to still carry code that is guarded with > "#ifndef CONFIG_NR_DRAM_BANKS" (and similar). This patch removes > all these unreferenced code paths. ...thus futher hiding where we just lost another lof of memory, for no advantage. Sic... Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de If programming was easy, they wouldn't need something as complicated as a human being to do it, now would they? - L. Wall & R. L. Schwartz, _Programming Perl_