From: Tom Rini Date: Tue, 18 Aug 2020 09:06:38 -0400 Subject: [PATCH v4 1/9] CONFIG_NR_DRAM_BANKS: Remove unreferenced code as its always defined In-Reply-To: <20200818103132.690B1242DD7@gemini.denx.de> References: <20200813054800.469284-1-sr@denx.de> <20200813054800.469284-2-sr@denx.de> <20200818103132.690B1242DD7@gemini.denx.de> Message-ID: <20200818130638.GL20605@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tue, Aug 18, 2020 at 12:31:32PM +0200, Wolfgang Denk wrote: > Dear Stefan Roese, > > In message <20200813054800.469284-2-sr@denx.de> you wrote: > > Since commit 86cf1c82850f ("configs: Migrate CONFIG_NR_DRAM_BANKS") & > > commit 999a772d9f24 ("Kconfig: Migrate CONFIG_NR_DRAM_BANKS"), > > CONFIG_NR_DRAM_BANKS is always defined with a value (4 is default). > > Has there been any evaluation about the impact this change had on > both text and data sizes of the resulting U-Boot image? > Especially the default value of 4 makes no sense to me - whiy is > this not 1? The default value is 4 because that was the most commonly used value. Annoyingly enough, I don't have those logs around (either I did them on Google Compute, or it was on a build box we reinstalled and I didn't save the logs off of) but I'm fairly sure there wasn't a size change, that's one of my tests for these migrations (that does sometimes fail to catch things, I need to play with getting the data out of buildman in something I can filter more easily). -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: