From: Thomas Petazzoni Date: Tue, 18 Aug 2020 16:34:24 +0200 Subject: [PATCH v3 1/4] fs/squashfs: Add init. and clean-up functions to decompression In-Reply-To: <20200818143118.16422-2-joaomarcos.costa@bootlin.com> References: <20200818143118.16422-1-joaomarcos.costa@bootlin.com> <20200818143118.16422-2-joaomarcos.costa@bootlin.com> Message-ID: <20200818163424.5da7c549@windsurf.home> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello, In your commit title: spurious . after "init". On Tue, 18 Aug 2020 16:31:15 +0200 Joao Marcos Costa wrote: > -static struct squashfs_ctxt ctxt; > +struct squashfs_ctxt sqfs_ctxt; Why are you dropping the "static" here ? This symbol only needs to be visible from that file. If you keep the "static" keyword, you can keep the variable named "ctxt" and avoid a lengthy patch. > + ret = sqfs_decompressor_init(&sqfs_ctxt); See you're passing a reference to the squashfs context here, so this variable does not need to be visible by other files. Best regards, Thomas -- Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com