Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E354C433E1 for ; Tue, 18 Aug 2020 17:29:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4400020658 for ; Tue, 18 Aug 2020 17:29:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728488AbgHRR3E (ORCPT ); Tue, 18 Aug 2020 13:29:04 -0400 Received: from netrider.rowland.org ([192.131.102.5]:46283 "HELO netrider.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1726715AbgHRR3D (ORCPT ); Tue, 18 Aug 2020 13:29:03 -0400 Received: (qmail 153514 invoked by uid 1000); 18 Aug 2020 13:29:01 -0400 Date: Tue, 18 Aug 2020 13:29:01 -0400 From: Alan Stern To: Sergei Shtylyov Cc: Bastien Nocera , linux-usb@vger.kernel.org, Greg Kroah-Hartman Subject: Re: [PATCH v8 3/3] USB: Fix device driver race Message-ID: <20200818172901.GA152667@rowland.harvard.edu> References: <20200818110445.509668-1-hadess@hadess.net> <20200818110445.509668-3-hadess@hadess.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Tue, Aug 18, 2020 at 08:06:20PM +0300, Sergei Shtylyov wrote: > On 8/18/20 2:04 PM, Bastien Nocera wrote: > > + } else { > > printk(KERN_ERR "%s: error %d registering device " > > " driver %s\n", > > Unrelated but... hm, this string literal seems weird. GregKH, would it be OK if we fix it? > > > usbcore_name, retval, new_udriver->name); Indeed, an extra tab character snuck in there by mistake. It has been present ever since 2006, when the routine was originally added by commit 8bb54ab573ec ("usbcore: add usb_device_driver definition"). It's perfectly okay with me if someone wants to remove the extra tab. In fact, nowadays we'd remove the line break entirely. Alan Stern