Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5FE31C433E1 for ; Wed, 19 Aug 2020 09:16:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4555820639 for ; Wed, 19 Aug 2020 09:16:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726905AbgHSJQj (ORCPT ); Wed, 19 Aug 2020 05:16:39 -0400 Received: from mx2.suse.de ([195.135.220.15]:40198 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726702AbgHSJQi (ORCPT ); Wed, 19 Aug 2020 05:16:38 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id E182CAD80; Wed, 19 Aug 2020 09:17:03 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id 5FCBD1E1312; Wed, 19 Aug 2020 11:16:37 +0200 (CEST) Date: Wed, 19 Aug 2020 11:16:37 +0200 From: Jan Kara To: Mauricio Faria de Oliveira Cc: Jan Kara , linux-ext4@vger.kernel.org, dann frazier , Mauricio Faria de Oliveira , Jan Kara Subject: Re: [RFC PATCH v2 2/5] jbd2: introduce journal callbacks j_submit|finish_inode_data_buffers Message-ID: <20200819091637.GH1902@quack2.suse.cz> References: <20200810010210.3305322-1-mfo@canonical.com> <20200810010210.3305322-3-mfo@canonical.com> <20200818145204.GC1902@quack2.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Tue 18-08-20 22:20:08, Mauricio Faria de Oliveira wrote: > > > To opt-out of the default behavior (i.e., to do nothing), one has > > > to opt-in with a no-op function. > > > > Your Signed-off-by is missing for this patch. > > Oh, I thought it wasn't needed in RFC patches. Yes, it's not strictly needed if you don't want patches included yet. But usually they are present so that people have less things to worry about when preparing final submission :) Honza -- Jan Kara SUSE Labs, CR