Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B41A5C433E1 for ; Wed, 19 Aug 2020 10:20:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8A53E2072D for ; Wed, 19 Aug 2020 10:20:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ddeNY72z" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726873AbgHSKUd (ORCPT ); Wed, 19 Aug 2020 06:20:33 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:60308 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726642AbgHSKUc (ORCPT ); Wed, 19 Aug 2020 06:20:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1597832431; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kqp0RLzyiqP2qlHXa0F96YjomzHg0Znfw14m2ZHyBNo=; b=ddeNY72zWBZEiEwicV5XMMllsCFOIO1P4IqZ1B73KEwlITCAs9Saph+ZPVr3ajGscshQ01 6ni1TpoCRSbn/XpoqHxppQfKlZJk8nrB/5X2gFcHP951cj+qpfz2hrDrfuJ91Q9kuoHdLN A1oVpoyPdMIr6MDk87qwj8kLfc+8daQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-230-18LsJdPcPD-jHatudp4NLw-1; Wed, 19 Aug 2020 06:20:30 -0400 X-MC-Unique: 18LsJdPcPD-jHatudp4NLw-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C70371084C8C; Wed, 19 Aug 2020 10:20:28 +0000 (UTC) Received: from gondolin (ovpn-112-216.ams2.redhat.com [10.36.112.216]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0A4457A422; Wed, 19 Aug 2020 10:20:23 +0000 (UTC) Date: Wed, 19 Aug 2020 12:20:21 +0200 From: Cornelia Huck To: Marc Hartmayer Cc: , Thomas Huth , David Hildenbrand , Janosch Frank , Andrew Jones , Paolo Bonzini , Christian Borntraeger , linux-s390@vger.kernel.org Subject: Re: [kvm-unit-tests PATCH 1/4] common.bash: run `cmd` only if a test case was found Message-ID: <20200819122021.43dd6ba6.cohuck@redhat.com> In-Reply-To: <20200818130424.20522-2-mhartmay@linux.ibm.com> References: <20200818130424.20522-1-mhartmay@linux.ibm.com> <20200818130424.20522-2-mhartmay@linux.ibm.com> Organization: Red Hat GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Tue, 18 Aug 2020 15:04:21 +0200 Marc Hartmayer wrote: > It's only useful to run `cmd` in `for_each_unittest` if a test case > was found. This change allows us to remove the guards from the > functions `run_task` and `mkstandalone`. > > Reviewed-by: Andrew Jones > Signed-off-by: Marc Hartmayer > --- > run_tests.sh | 3 --- > scripts/common.bash | 8 ++++++-- > scripts/mkstandalone.sh | 4 ---- > 3 files changed, 6 insertions(+), 9 deletions(-) Reviewed-by: Cornelia Huck