From: Tom Rini Date: Wed, 19 Aug 2020 08:37:05 -0400 Subject: [PATCH 5/9] cmd: Kconfig: Change dependency of CMD_USB_SDP In-Reply-To: <7690882a389d8172e484a22c737a29cf7afaa526.1597826658.git.michal.simek@xilinx.com> References: <7690882a389d8172e484a22c737a29cf7afaa526.1597826658.git.michal.simek@xilinx.com> Message-ID: <20200819123705.GU20605@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wed, Aug 19, 2020 at 10:44:19AM +0200, Michal Simek wrote: > USB_FUNCTION_SDP depends on USB_GADGET_DOWNLOAD to be enabled which is not > reflect in Kconfig. Fix it by changing select to depends on for CMD_USB_SDP > command. > Kconfig is reporting it as: > WARNING: unmet direct dependencies detected for USB_FUNCTION_SDP > Depends on [n]: USB [=n] && USB_GADGET [=n] && USB_GADGET_DOWNLOAD [=n] > Selected by [y]: > - CMD_USB_SDP [=y] > > Signed-off-by: Michal Simek > --- > > cmd/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/cmd/Kconfig b/cmd/Kconfig > index bd3559ae6c12..f291c8cbf423 100644 > --- a/cmd/Kconfig > +++ b/cmd/Kconfig > @@ -1351,7 +1351,7 @@ config CMD_USB > > config CMD_USB_SDP > bool "sdp" > - select USB_FUNCTION_SDP > + depends on USB_FUNCTION_SDP > help > Enables the command "sdp" which is used to have U-Boot emulating the > Serial Download Protocol (SDP) via USB. Based on usage, USB_FUNCTION_SDP looks to really be a library type function. Adding some iMX folks as it's used there, and Lokesh since the K2G platforms enable the library side, but I don't think use it? -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: