From: Tom Rini Date: Wed, 19 Aug 2020 08:38:43 -0400 Subject: [PATCH 8/9] cmd: Kconfig: Fix dependencies for CMD_USB_MASS_STORAGE In-Reply-To: References: Message-ID: <20200819123843.GV20605@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wed, Aug 19, 2020 at 10:44:22AM +0200, Michal Simek wrote: > There are missing dependencies for selecting USB_FUNCTION_MASS_STORAGE. > Change select to depends on instead of selecting all required options. > Kconfig reports this issue as: > WARNING: unmet direct dependencies detected for USB_FUNCTION_MASS_STORAGE > Depends on [n]: USB [=n] && USB_GADGET [=n] && USB_GADGET_DOWNLOAD [=n] > Selected by [y]: > - CMD_USB_MASS_STORAGE [=y] > > Signed-off-by: Michal Simek > --- > > cmd/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/cmd/Kconfig b/cmd/Kconfig > index f291c8cbf423..eebaaa420bf1 100644 > --- a/cmd/Kconfig > +++ b/cmd/Kconfig > @@ -1367,7 +1367,7 @@ config CMD_ROCKUSB > > config CMD_USB_MASS_STORAGE > bool "UMS usb mass storage" > - select USB_FUNCTION_MASS_STORAGE > + depends on USB_FUNCTION_MASS_STORAGE > help > USB mass storage support Similar to the SDP issue, perhaps we have USB symbols that in turn need to be select'ing other library functions they use? -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: