Content-Type: multipart/mixed; boundary="===============6604814849821554049==" MIME-Version: 1.0 From: kernel test robot To: kbuild-all@lists.01.org Subject: [PATCH] fix boolreturn.cocci warnings Date: Thu, 20 Aug 2020 02:47:31 +0800 Message-ID: <20200819184731.GA63215@c4ca2a659865> In-Reply-To: <20200819043409.26010-1-nischal.varide@intel.com> List-Id: --===============6604814849821554049== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: kernel test robot drivers/gpu/drm/i915/display/intel_atomic.c:199:9-10: WARNING: return of 0/= 1 in function 'intel_connector_needs_modeset' with return type bool Return statements in functions returning bool should use true/false instead of 1/0. Generated by: scripts/coccinelle/misc/boolreturn.cocci CC: Nischal Varide Signed-off-by: kernel test robot --- url: https://github.com/0day-ci/linux/commits/Nischal-Varide/Critical-Kc= lockWork-Fixes-intel_atomi-c-PossibleNull/20200819-193249 base: git://anongit.freedesktop.org/drm-intel for-linux-next intel_atomic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/gpu/drm/i915/display/intel_atomic.c +++ b/drivers/gpu/drm/i915/display/intel_atomic.c @@ -196,7 +196,7 @@ intel_connector_needs_modeset(struct int old_conn_state =3D drm_atomic_get_old_connector_state(&state->base, conne= ctor); new_conn_state =3D drm_atomic_get_new_connector_state(&state->base, conne= ctor); if (!(old_conn_state && new_conn_state)) - return 0; + return false; = return old_conn_state->crtc !=3D new_conn_state->crtc || (new_conn_state->crtc && --===============6604814849821554049==--