Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 468C5C433E1 for ; Mon, 24 Aug 2020 07:45:20 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 08B99206BE for ; Mon, 24 Aug 2020 07:45:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="J0qjZJGG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 08B99206BE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=dEQ2rLh6lWVDBBrfFgdmAmUp5U4Q26YEwM+CQDuKacE=; b=J0qjZJGGZRiUwq1fLEyimKI7rh MCT/q3NAdIuC8yqkxeHgI8sxuc9JOnsf3oRKLZAlF6BVSLI12dgjmSKAhAtJfAaeL3rDBMirUKhHf UX2FnPGBrDd8Ib5DNAuYURFLtkErVK2JnF8eQ6GymRa0qrPUWPgUlotEPfOuUJCmU0TgtfV5V117v aphhqAxbPwJ3uUiEpOO8iTW+4a+4Yu2eSzK+xQvTaZTycKYc7trK1ucBG7x3PZknUnxZpkHDz/FVC NNBp43IYNVoYkylXNiT6ZibHplrxCI3PVnlA3utp2GOGdPviXGqASd1DH9ri+c9YeRthDLMJ4lXML ABAMtn0Q==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kA78i-0007ii-0y; Mon, 24 Aug 2020 07:43:36 +0000 Received: from szxga06-in.huawei.com ([45.249.212.32] helo=huawei.com) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kA78d-0007hc-AU for linux-arm-kernel@lists.infradead.org; Mon, 24 Aug 2020 07:43:33 +0000 Received: from DGGEMS413-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 5B26AB2B4A9B630869F6; Mon, 24 Aug 2020 15:43:21 +0800 (CST) Received: from huawei.com (10.175.127.227) by DGGEMS413-HUB.china.huawei.com (10.3.19.213) with Microsoft SMTP Server id 14.3.487.0; Mon, 24 Aug 2020 15:43:12 +0800 From: Ye Bin To: , , , Subject: [PATCH] irqchip/ti-sci-inta: Fix unsigned expression compared with zero in ti_sci_inta_alloc_parent_irq Date: Mon, 24 Aug 2020 15:42:58 +0800 Message-ID: <20200824074258.160286-1-yebin10@huawei.com> X-Mailer: git-send-email 2.25.4 MIME-Version: 1.0 X-Originating-IP: [10.175.127.227] X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200824_034331_616903_E54BE410 X-CRM114-Status: UNSURE ( 8.77 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ye Bin Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Signed-off-by: Ye Bin --- drivers/irqchip/irq-ti-sci-inta.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/irqchip/irq-ti-sci-inta.c b/drivers/irqchip/irq-ti-sci-inta.c index d4e97605456b..37d09cbdc15c 100644 --- a/drivers/irqchip/irq-ti-sci-inta.c +++ b/drivers/irqchip/irq-ti-sci-inta.c @@ -182,12 +182,13 @@ static struct ti_sci_inta_vint_desc *ti_sci_inta_alloc_parent_irq(struct irq_dom if (vint_id == TI_SCI_RESOURCE_NULL) return ERR_PTR(-EINVAL); - p_hwirq = ti_sci_inta_xlate_irq(inta, vint_id); - if (p_hwirq < 0) { - ret = p_hwirq; + ret = ti_sci_inta_xlate_irq(inta, vint_id); + if (ret < 0) { goto free_vint; } + p_hwirq = ret; + vint_desc = kzalloc(sizeof(*vint_desc), GFP_KERNEL); if (!vint_desc) { ret = -ENOMEM; -- 2.25.4 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel