Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCFDFC433E1 for ; Thu, 27 Aug 2020 12:38:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 93B442177B for ; Thu, 27 Aug 2020 12:38:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="AAfIu5fz" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728899AbgH0MhO (ORCPT ); Thu, 27 Aug 2020 08:37:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39984 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729085AbgH0Me0 (ORCPT ); Thu, 27 Aug 2020 08:34:26 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B203CC061264 for ; Thu, 27 Aug 2020 05:34:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=4TJCMywC/u0Jjft8iJm8hz2bTyeQ36xiar1IeZSVsz0=; b=AAfIu5fz/lgCQyjXPXcZdWlPkY jD02lsrSmjJXRsAWgTDs0bvTDr5IiqiMK7m5AB6+8abXXObVuJ195m5vvQi1Fu2pezxruBbjRUk4L Dh8aPrV57JSL87Tz6zmkSiXLIHEXUH6Ol82fXjqSCrdF+XCxoRE3lDCg2qoJGrcrNJXPQcto9M0Ec gvs44NnJQUL175WoeFVkH27iDynz5GKCroJUfdtPCuD1yHvNEyVWUMyIMyCLiZ/6i5fJ+S6tiezJq iiOMgJHIuAscGd53x+vwzkq99CQAx7XbwuTKWMmza349+DXcfFwbubXNu9qyw+w6Fkv8ZFEKtIG2V PmcvGiPA==; Received: from willy by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kBH6m-0002a0-Ek; Thu, 27 Aug 2020 12:34:24 +0000 Date: Thu, 27 Aug 2020 13:34:24 +0100 From: Matthew Wilcox To: Pradeep P V K Cc: miklos@szeredi.hu, linux-fsdevel@vger.kernel.org, stummala@codeaurora.org, sayalil@codeaurora.org Subject: Re: [PATCH V2] fuse: Fix VM_BUG_ON_PAGE issue while accessing zero ref count page Message-ID: <20200827123424.GF14765@casper.infradead.org> References: <1598452035-3472-1-git-send-email-ppvk@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1598452035-3472-1-git-send-email-ppvk@codeaurora.org> Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Wed, Aug 26, 2020 at 07:57:15PM +0530, Pradeep P V K wrote: > Fix this by protecting fuse_copy_pages() with fc->lock. No. This is a spinlock and fuse_copy_pages() can allocate memory with GFP_KERNEL. You need to enable more debugging on your test system.