Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BEE9C433E6 for ; Sat, 29 Aug 2020 06:57:27 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E111F20738 for ; Sat, 29 Aug 2020 06:57:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="GvYwAFqq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E111F20738 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id B0B1C8844B; Sat, 29 Aug 2020 06:57:26 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hpT63ysdE70j; Sat, 29 Aug 2020 06:57:26 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by hemlock.osuosl.org (Postfix) with ESMTP id EF80188418; Sat, 29 Aug 2020 06:57:25 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id D74DFC016F; Sat, 29 Aug 2020 06:57:25 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by lists.linuxfoundation.org (Postfix) with ESMTP id BB0AFC0051 for ; Sat, 29 Aug 2020 06:57:24 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id A4DE9878BE for ; Sat, 29 Aug 2020 06:57:24 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6hHUbQMbgV3M for ; Sat, 29 Aug 2020 06:57:22 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by whitealder.osuosl.org (Postfix) with ESMTPS id 65C8E866DD for ; Sat, 29 Aug 2020 06:57:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=dr5JH0lgv6z4waLYIZjOlCHTsfO75mqbdWo74Ywkptc=; b=GvYwAFqqCC0427Cxpi+s9mzKFv FAbjjFYXssUdVGjzzXoxsZxEqSrVZepxxCmLfaUaynbQya4h0xFCEbMhNX/TbINETbx8OAQvdExil VdoX6y1iIBsZSQEGUZ+gEoC3jXpnp88llnUrAV/QNF9rK6/AJ5XUsbdp2kWttYxi27swhZxl8b/Pi pvbMQ83cmcav2unHo9YNmSB7jxiSJf93twhFCcw13hZoAenzcb2Uc5M8ia44AKWTnjhFmHggLzIFZ Xoq0PvzCVu7AaSOd6HBryU557ntbnGHr9tZMkrWCYWFaFoYQWoFn5TdLKixTkeihfP1PpGy4+Pk/w yj5prb2Q==; Received: from hch by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kBund-0000Bw-HS; Sat, 29 Aug 2020 06:57:17 +0000 Date: Sat, 29 Aug 2020 07:57:17 +0100 From: Christoph Hellwig To: Andy Shevchenko Subject: Re: [PATCH v1] iommu/dma: Use DMA ops setter instead of direct assignment Message-ID: <20200829065717.GA31681@infradead.org> References: <20200828111310.8032-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200828111310.8032-1-andriy.shevchenko@linux.intel.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Cc: iommu@lists.linux-foundation.org X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On Fri, Aug 28, 2020 at 02:13:10PM +0300, Andy Shevchenko wrote: > Use DMA ops setter instead of direct assignment. Even we know that > this module doesn't perform access to the dma_ops member of struct device, > it's better to use setter to avoid potential problems in the future. I as actually planning on killing off set_dma_ops (and get_dma_ops) for the 5.10 merge window. The rationale is that code that sets or gets DMA ops per definition is deeply dependent on not just DMA support, but also on DMA ops which have their own options as of 5.9. Additional that WIP series removes the dma_map_ops definition from dma-mapping.h into a private header only used in the few places that do have a business messing with DMA ops. _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu