Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84581C433E6 for ; Sun, 30 Aug 2020 08:36:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5DA8120714 for ; Sun, 30 Aug 2020 08:36:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728621AbgH3IgA (ORCPT ); Sun, 30 Aug 2020 04:36:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50456 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726284AbgH3IgA (ORCPT ); Sun, 30 Aug 2020 04:36:00 -0400 Received: from gofer.mess.org (gofer.mess.org [IPv6:2a02:8011:d000:212::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D3A2BC061573 for ; Sun, 30 Aug 2020 01:35:59 -0700 (PDT) Received: by gofer.mess.org (Postfix, from userid 1000) id 82D71C63F6; Sun, 30 Aug 2020 09:35:57 +0100 (BST) Date: Sun, 30 Aug 2020 09:35:57 +0100 From: Sean Young To: Daniel Gielen Cc: mchehab@kernel.org, Linux Media Mailing List Subject: Re: [PATCH] DVBSKY S952v1 (M88TS2020 tuner, M88DS3103 demod): Set clk_out_div to 1 for M88TS2020, 0 locks up demod M88DS3103 Message-ID: <20200830083557.GA17813@gofer.mess.org> References: <20200502211809.3906-1-gielendaniel@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200502211809.3906-1-gielendaniel@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Sat, May 02, 2020 at 11:18:09PM +0200, Daniel Gielen wrote: > Signed-off-by: Daniel Gielen Please can we have a better commit message, explaining what behaviour you seeing before the patch and how this fixes it. A bisect which show what regression you are fixing would also be helpful. Thanks, Sean > --- > drivers/media/pci/cx23885/cx23885-dvb.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/media/pci/cx23885/cx23885-dvb.c b/drivers/media/pci/cx23885/cx23885-dvb.c > index 45c2f4afc..7123e1487 100644 > --- a/drivers/media/pci/cx23885/cx23885-dvb.c > +++ b/drivers/media/pci/cx23885/cx23885-dvb.c > @@ -2139,6 +2139,7 @@ static int dvb_register(struct cx23885_tsport *port) > memset(&ts2020_config, 0, sizeof(ts2020_config)); > ts2020_config.fe = fe0->dvb.frontend; > ts2020_config.get_agc_pwm = m88ds3103_get_agc_pwm; > + ts2020_config.clk_out_div = 1; > memset(&info, 0, sizeof(struct i2c_board_info)); > strscpy(info.type, "ts2020", I2C_NAME_SIZE); > info.addr = 0x60; > -- > 2.25.1