Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F402C433E6 for ; Tue, 1 Sep 2020 10:09:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DD175206A5 for ; Tue, 1 Sep 2020 10:09:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726212AbgIAKJW (ORCPT ); Tue, 1 Sep 2020 06:09:22 -0400 Received: from verein.lst.de ([213.95.11.211]:52810 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725949AbgIAKJI (ORCPT ); Tue, 1 Sep 2020 06:09:08 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 8047868B05; Tue, 1 Sep 2020 12:09:04 +0200 (CEST) Date: Tue, 1 Sep 2020 12:09:04 +0200 From: Christoph Hellwig To: Ming Lei Cc: Jens Axboe , linux-block@vger.kernel.org, Ilya Dryomov , Luis Chamberlain , Christoph Hellwig , Bart Van Assche Subject: Re: [PATCH V2] block: release disk reference in hd_struct_free_work Message-ID: <20200901100904.GA9278@lst.de> References: <20200901100738.317061-1-ming.lei@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200901100738.317061-1-ming.lei@redhat.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Tue, Sep 01, 2020 at 06:07:38PM +0800, Ming Lei wrote: > Commit e8c7d14ac6c3 ("block: revert back to synchronous request_queue removal") > stops to release request queue from wq context because that commit > supposed all blk_put_queue() is called in context which is allowed > to sleep. However, this assumption isn't true because we release disk's > reference in partition's percpu_ref's ->release() which doesn't allow > to sleep, because the ->release() is run via call_rcu(). > > Fixes this issue by moving put disk reference into hd_struct_free_work() > > Signed-off-by: Ming Lei > Fixes: e8c7d14ac6c3 ("block: revert back to synchronous request_queue removal") > Reported-by: Ilya Dryomov > Tested-by: Ilya Dryomov > Cc: Luis Chamberlain > Cc: Christoph Hellwig > Cc: Bart Van Assche Looks good, Reviewed-by: Christoph Hellwig