Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 521B2C433E7 for ; Wed, 2 Sep 2020 15:05:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3140220773 for ; Wed, 2 Sep 2020 15:05:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727918AbgIBPFM (ORCPT ); Wed, 2 Sep 2020 11:05:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46106 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727824AbgIBPEp (ORCPT ); Wed, 2 Sep 2020 11:04:45 -0400 Received: from orbyte.nwl.cc (orbyte.nwl.cc [IPv6:2001:41d0:e:133a::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CF0DBC061244 for ; Wed, 2 Sep 2020 08:04:44 -0700 (PDT) Received: from n0-1 by orbyte.nwl.cc with local (Exim 4.94) (envelope-from ) id 1kDUJX-00072t-8y; Wed, 02 Sep 2020 17:04:43 +0200 Date: Wed, 2 Sep 2020 17:04:43 +0200 From: Phil Sutter To: Pablo Neira Ayuso Cc: netfilter-devel@vger.kernel.org, eric@garver.life Subject: Re: [PATCH nf,v2] netfilter: nf_tables: coalesce multiple notifications into one skbuff Message-ID: <20200902150443.GE23632@orbyte.nwl.cc> Mail-Followup-To: Phil Sutter , Pablo Neira Ayuso , netfilter-devel@vger.kernel.org, eric@garver.life References: <20200902145202.6822-1-pablo@netfilter.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200902145202.6822-1-pablo@netfilter.org> Sender: netfilter-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org On Wed, Sep 02, 2020 at 04:52:02PM +0200, Pablo Neira Ayuso wrote: [...] > +static void nft_commit_notify(struct net *net, u32 portid) > +{ > + struct sk_buff *batch_skb = NULL, *nskb, *skb; > + unsigned char *data; > + int len; > + > + list_for_each_entry_safe(skb, nskb, &net->nft.notify_list, list) { > + if (!batch_skb) { > +new_batch: > + batch_skb = skb; > + NFT_CB(batch_skb).report = NFT_CB(skb).report; Is this assignment needed? NFT_CB() merely dereferences skb->cb, so after assigning 'batch_skb = skb', NFT_CB(batch_skb) == NFT_CB(skb), no? (Sorry for the late complaint, I forgot about it until reviewing your v2.) Cheers, Phil