Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F464C43461 for ; Mon, 7 Sep 2020 11:45:58 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0E6FC2067C for ; Mon, 7 Sep 2020 11:45:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0E6FC2067C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1FDDD8929C; Mon, 7 Sep 2020 11:45:57 +0000 (UTC) Received: from asavdk3.altibox.net (asavdk3.altibox.net [109.247.116.14]) by gabe.freedesktop.org (Postfix) with ESMTPS id DE9678929C for ; Mon, 7 Sep 2020 11:45:55 +0000 (UTC) Received: from ravnborg.org (unknown [188.228.123.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id 184F420024; Mon, 7 Sep 2020 13:45:54 +0200 (CEST) Date: Mon, 7 Sep 2020 13:45:52 +0200 From: Sam Ravnborg To: Neil Armstrong Subject: Re: [PATCH v2 2/3] dt-bindings: display: panel: add TDO tl070wsh30 DSI panel bindings Message-ID: <20200907114552.GA526406@ravnborg.org> References: <20200907111027.21933-1-narmstrong@baylibre.com> <20200907111027.21933-3-narmstrong@baylibre.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200907111027.21933-3-narmstrong@baylibre.com> X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=CaYmGojl c=1 sm=1 tr=0 a=S6zTFyMACwkrwXSdXUNehg==:117 a=S6zTFyMACwkrwXSdXUNehg==:17 a=kj9zAlcOel0A:10 a=IpJZQVW2AAAA:8 a=gEfo2CItAAAA:8 a=3nj7rlk6SGwJzBwD0W8A:9 a=CjuIK1q_8ugA:10 a=IawgGOuG5U0WyFbmm1f5:22 a=sptkURWiP4Gy88Gu7hUp:22 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, thierry.reding@gmail.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-amlogic@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Neil. On Mon, Sep 07, 2020 at 01:10:26PM +0200, Neil Armstrong wrote: > This add the bindings for the 1024*600 tl070wsh30 DSI panel. The binding looks like a panel-simple-dsi.yaml candidate. Only differen is enable-gpios versus reset-gpios Could you check if we can use panel-simple-dsi-yaml. Sam > > Signed-off-by: Neil Armstrong > --- > .../display/panel/tdo,tl070wsh30.yaml | 58 +++++++++++++++++++ > 1 file changed, 58 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/panel/tdo,tl070wsh30.yaml > > diff --git a/Documentation/devicetree/bindings/display/panel/tdo,tl070wsh30.yaml b/Documentation/devicetree/bindings/display/panel/tdo,tl070wsh30.yaml > new file mode 100644 > index 000000000000..20f4fdedfcb0 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/panel/tdo,tl070wsh30.yaml > @@ -0,0 +1,58 @@ > +# SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause) > +# Copyright 2020 BayLibre, SAS > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/panel/tdo,tl070wsh30.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: TDO TL070WSH30 DSI panel > + > +maintainers: > + - Neil Armstrong > + > +allOf: > + - $ref: panel-common.yaml# > + > +properties: > + > + compatible: > + enum: > + - tdo,tl070wsh30 > + > + reg: > + maxItems: 1 > + description: DSI virtual channel > + > + backlight: true > + reset-gpios: true > + port: true > + power-supply: true > + > +additionalProperties: false > + > +required: > + - compatible > + - power-supply > + - reset-gpios > + - port > + - reg > + > +examples: > + - | > + dsi { > + #address-cells = <1>; > + #size-cells = <0>; > + panel@0 { > + compatible = "tdo,tl070wsh30"; > + reg = <0>; > + power-supply = <&vcc_lcd_reg>; > + backlight = <&panel_backlight>; > + reset-gpios = <&gpio_reset>; > + > + port { > + panel: endpoint { > + remote-endpoint = <&mipi_dsi_out>; > + }; > + }; > + }; > + }; > -- > 2.22.0 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel