Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1450BC433E2 for ; Thu, 10 Sep 2020 05:53:33 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9BEF12075B for ; Thu, 10 Sep 2020 05:53:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="pqfWunPS"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="azvVm+IW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9BEF12075B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id EDB5E1676; Thu, 10 Sep 2020 07:52:39 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz EDB5E1676 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1599717210; bh=Rr43ETN5BnzQnh/AFr/VfVFBOAJWVE/smD7x0ee6+uw=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=pqfWunPSv3l7kaLAcHONalQa/EpnqWzZh5DM4/J6sLZ3r0OZVz4zaCoDJ79+XsLUw 0m4zcJr6NoPrIgsRLiafHsW+iZrEiFysjO6QBr+oxDabsJlZVsr4M6/HcJR5GTzsmf Q8L/KMzXTQeGKRVYVpIaCRnpYwR9beUPyGHW+dKQ= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 1D5E0F80272; Thu, 10 Sep 2020 07:52:32 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 7A17FF8026F; Thu, 10 Sep 2020 07:52:31 +0200 (CEST) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id E7B0FF8026F for ; Thu, 10 Sep 2020 07:52:25 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz E7B0FF8026F Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="azvVm+IW" Received: from localhost (unknown [122.179.50.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 95A3A2080A; Thu, 10 Sep 2020 05:52:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599717143; bh=Rr43ETN5BnzQnh/AFr/VfVFBOAJWVE/smD7x0ee6+uw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=azvVm+IWvehvYY+s1HCB4ERwEKVwMQ5t9T1K3DBKkeP1KKsj+f4itjrORb7vzMxDm 6dyZwRwHF1To/S7EAf0hqf5w/FLkkvVMwYFQHo3s8XTjnY88179Z3DOt8SERJY8H0h qgISUJwBsyUeD3yj2ZFrbUgEu3M8YR2JF1g6AMC0= Date: Thu, 10 Sep 2020 11:22:15 +0530 From: Vinod Koul To: Pierre-Louis Bossart Subject: Re: [PATCH -next] soundwire: intel: Remove ununsed function Message-ID: <20200910055215.GP77521@vkoul-mobl> References: <20200909131531.31380-1-yuehaibing@huawei.com> <14a09132-d0ed-7129-73df-cbeb3154429b@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <14a09132-d0ed-7129-73df-cbeb3154429b@linux.intel.com> Cc: yung-chuan.liao@linux.intel.com, sanyog.r.kale@intel.com, YueHaibing , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 09-09-20, 08:46, Pierre-Louis Bossart wrote: > > > On 9/9/20 8:15 AM, YueHaibing wrote: > > If CONFIG_PM is not set, build warns: > > > > drivers/soundwire/intel.c:488:12: warning: 'intel_link_power_down' defined but not used [-Wunused-function] > > > > Move this to #ifdef block. > > Yes, thanks for the report, it's a valid issue, but maybe the fix is to add > __maybe_unused more consistently and remove the CONFIG_PM dependency. > > Vinod, what would you prefer? __maybe_unused is the recommendation, it should be updated to use that Thanks -- ~Vinod