Received: by 2002:ac2:4c26:0:0:0:0:0 with SMTP id u6csp1136121lfq; Thu, 10 Sep 2020 02:15:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwH8zj7WafDj2/nDtuqZX9bj2dQXKm2BSUai45kzAK5oXoe80n42T46hALi/iNgIuWHCEWz X-Received: by 2002:a25:317:: with SMTP id 23mr11748448ybd.233.1599729335603; Thu, 10 Sep 2020 02:15:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599729335; cv=none; d=google.com; s=arc-20160816; b=pl/q6FWtYBqaXqlVxP61BhdOJSxLHcuI44VU7fxqdmzZBRhIyqZZ2jp5/NhWnBNYZD delq8xsEcEO3PissglSED2y57nsMAjIYIws9TG5EmAOu5+d7DbzQI3xoGnBFwblQDbFi bOFp1dxvIvsEJwkSVmDnj9lOLFIW88nKvczFviU+h0fiBq8h+kfiBkMLGYSnL6pLp8Jn q5oQN2Umo5SkDVpojzwdVQkKlEZobOSPmDbs2OUDERSDivOUKlB3KpaY5feWzxvy6qaA g5K1FubTW6M2BtAJn4rDyBWqz0uy33DYFaFnXEQGAulhQvESaMF7grjmspoTuhnTsVe8 f/jA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=W4LhbyuqlF5S6rmEVd7X2hXE/FDCj8fqPB7MayxFhdk=; b=mtMyu4ED7iIS5VTqJOeBQDazGpJghxNqcmE2qxJFJd1FVcmCw30ZuEI8ZR5nK1rEva eNQRBBjQOzyILXLD13eQ7mPdTrXZYgN1388AQsAsw5ngAFDc5yR0TjjxSPce7AZUNB5C EFCt+iSc298Zg/rvWS4itF1Jtb95hKM8PQUKhDEnq8c8S90W2wAHkiSvGa4b4SBC+pF8 4DPMo5aSGV6jc3uR+Bdv3jvuiECOS/R8NDbgCQ0MWDPaH2cJQcfmyeIIOIMJSqtQ11NZ a13zEfvkjmu8vRo0+t/hD9PotEEEccfxP1A14lB50MGU4en9C74QuiakIRgs8mLDzHj8 jTgQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=D7Whzn8q; spf=pass (google.com: domain of berrange@redhat.com designates 205.139.110.61 as permitted sender) smtp.mailfrom=berrange@redhat.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com. [205.139.110.61]) by mx.google.com with ESMTPS id h77si5032134ybg.39.2020.09.10.02.15.35 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 10 Sep 2020 02:15:35 -0700 (PDT) Received-SPF: pass (google.com: domain of berrange@redhat.com designates 205.139.110.61 as permitted sender) client-ip=205.139.110.61; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=D7Whzn8q; spf=pass (google.com: domain of berrange@redhat.com designates 205.139.110.61 as permitted sender) smtp.mailfrom=berrange@redhat.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1599729335; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=W4LhbyuqlF5S6rmEVd7X2hXE/FDCj8fqPB7MayxFhdk=; b=D7Whzn8qu+qo1BlV8HTuOZmyl5eCOrh04qU7FeqM+klZtbkZ8qS7q4XGwlMnq1XMYDkyxC Hj5Xkee9YQRe8FFlY2sRBvCfSeybpE/wFpjCr+jGC9LILSGo/09ERXatzo8TlmteUdsTkh TF8lffUsEOJ1ctvcKKPBHO++6YNCwzU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-494-j17T7367PC2YHoZh06ZP8g-1; Thu, 10 Sep 2020 05:15:09 -0400 X-MC-Unique: j17T7367PC2YHoZh06ZP8g-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3A0481091061; Thu, 10 Sep 2020 09:15:07 +0000 (UTC) Received: from redhat.com (ovpn-112-4.ams2.redhat.com [10.36.112.4]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EA18960C07; Thu, 10 Sep 2020 09:14:56 +0000 (UTC) Date: Thu, 10 Sep 2020 10:14:54 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Thomas Huth Cc: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org, Laurent Vivier , Peter Maydell , Alistair Francis , Eduardo Habkost , kvm@vger.kernel.org, "Michael S. Tsirkin" , Andrew Jeffery , Jason Wang , Marcelo Tosatti , Joel Stanley , qemu-trivial@nongnu.org, qemu-arm@nongnu.org, =?utf-8?Q?C=C3=A9dric?= Le Goater , Paolo Bonzini , "Edgar E. Iglesias" , Alex =?utf-8?Q?Benn=C3=A9e?= , Richard Henderson Subject: Re: [PATCH 5/6] hw/pci-host/q35: Rename PCI 'black hole as '(memory) hole' Message-ID: <20200910091454.GE1083348@redhat.com> Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= References: <20200910070131.435543-1-philmd@redhat.com> <20200910070131.435543-6-philmd@redhat.com> <7dbdef90-1ca6-bf27-7084-af0c716d01d9@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <7dbdef90-1ca6-bf27-7084-af0c716d01d9@redhat.com> User-Agent: Mutt/1.14.6 (2020-07-11) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-TUID: 9fF6ZYO0B+tq On Thu, Sep 10, 2020 at 09:15:02AM +0200, Thomas Huth wrote: > On 10/09/2020 09.01, Philippe Mathieu-Daudé wrote: > > In order to use inclusive terminology, rename "blackhole" > > as "(memory)hole". > > A black hole is a well-known astronomical term, which is simply named > that way since it absorbes all light. I doubt that anybody could get > upset by this term? In this particular case I think the change is the right thing to do simply because the astronomical analogy is not adding any value in understanding. Calling it a "memoryhole" is more descriptive in what is actually is. > > > Signed-off-by: Philippe Mathieu-Daudé > > --- > > include/hw/pci-host/q35.h | 4 ++-- > > hw/pci-host/q35.c | 38 +++++++++++++++++++------------------- > > tests/qtest/q35-test.c | 2 +- > > 3 files changed, 22 insertions(+), 22 deletions(-) > > > > diff --git a/include/hw/pci-host/q35.h b/include/hw/pci-host/q35.h > > index 070305f83df..0fb90aca18b 100644 > > --- a/include/hw/pci-host/q35.h > > +++ b/include/hw/pci-host/q35.h > > @@ -48,8 +48,8 @@ typedef struct MCHPCIState { > > PAMMemoryRegion pam_regions[13]; > > MemoryRegion smram_region, open_high_smram; > > MemoryRegion smram, low_smram, high_smram; > > - MemoryRegion tseg_blackhole, tseg_window; > > - MemoryRegion smbase_blackhole, smbase_window; > > + MemoryRegion tseg_hole, tseg_window; > > + MemoryRegion smbase_hole, smbase_window; > > Maybe rather use smbase_memhole and tseg_memhole? > > Thomas > > Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|