Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E863C43461 for ; Thu, 10 Sep 2020 18:31:45 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D87522080A for ; Thu, 10 Sep 2020 18:31:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D87522080A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=m5p.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kGRLs-0003MU-3j; Thu, 10 Sep 2020 18:31:20 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kGRLq-0003MP-Ky for xen-devel@lists.xenproject.org; Thu, 10 Sep 2020 18:31:18 +0000 X-Inumbo-ID: ed163d78-7ade-4e6b-b7c7-e8badee8751a Received: from mailhost.m5p.com (unknown [74.104.188.4]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id ed163d78-7ade-4e6b-b7c7-e8badee8751a; Thu, 10 Sep 2020 18:31:17 +0000 (UTC) Received: from m5p.com (mailhost.m5p.com [IPv6:2001:470:1f07:15ff:0:0:0:f7]) by mailhost.m5p.com (8.15.2/8.15.2) with ESMTPS id 08AIV0I9045982 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Thu, 10 Sep 2020 14:31:06 -0400 (EDT) (envelope-from ehem@m5p.com) Received: (from ehem@localhost) by m5p.com (8.15.2/8.15.2/Submit) id 08AIV0S2045981; Thu, 10 Sep 2020 11:31:00 -0700 (PDT) (envelope-from ehem) Date: Thu, 10 Sep 2020 11:31:00 -0700 From: Elliott Mitchell To: Jan Beulich Cc: xen-devel@lists.xenproject.org, Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu , Doug Goldstein , Daniel De Graaf , Christian Lindig , David Scott , Samuel Thibault Subject: Re: [PATCH 00/11] Major rework of top-level .gitignore Message-ID: <20200910183100.GC45655@mattapan.m5p.com> References: <202009092152.089Lqhmn039171@m5p.com> <7b7d69c5-5237-2290-06d8-3aae436257dc@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7b7d69c5-5237-2290-06d8-3aae436257dc@suse.com> X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On Thu, Sep 10, 2020 at 08:10:08AM +0200, Jan Beulich wrote: > On 09.09.2020 03:28, Elliott Mitchell wrote: > > The top-level .gitignore file for Xen has gotten rather messy. Looks > > like at times a few people may have added some blank lines looking > > towards some later cleanup. Alas no one ever got around to that later > > cleanup. > > > > When looking at one portion of the situation I ended up doing some > > cleanup and it got out of hand. Hence I'm not sending in these patches > > which hopefully make things better. > > > > Please note these are somewhat better than work-in-progress status. > > There are several places I'm unsure of which direction to go in. Likely > > several of these will need more or less information in their commit > > messages. > > > > Overall pattern is first some initial cleanup on the top-level > > .gitignore. It is easier to spot targeted file matches which overlapped > > general globs before breaking things apart. This is followed by breaking > > all targeted matches off of the global .gitignore file. Lastly the > > global .gitignore file was sorted and I've commented on a few of the > > things which remain. > > > > Recent versions of `git` include a "check-ignore" command. For testing > > new patterns `git check-ignore -vn --no-index ` will tell you > > whether a given filename would be ignored without "add -f". > > > > I think patches 01 and 02 are near ready for being committed. > > Provided we as a community basically agree on the splitting. I'm > not sure I've read this out of prior discussion. Looking at things, I think this is the way to go. The older OCAML pieces needs some ignores which are distinct from what C or Python need. Several portions of Xen appear to need some local patterns which differ from what is in the general portion. The downside of splitting is it makes it harder to identify patterns which everyone has implemented variants of and should be moved to a general pattern in the top-level .gitignore file. > > Patches > > 03-09 need varying degrees of polish before being in an official tree. > > Patches 10 and 11 are pretty well initial rough outlines. > > > > Elliott Mitchell (11): > > gitignore: Move ignores from global to subdirectories > > gitignore: Remove entries duplicating global entries > > gitignore: Add/Generalize entries > > gitignore: Create .gitignore file for tools/firmware/ > > gitignore: Create .gitignore file for tools/ocaml/ > > gitignore: Create .gitignore file for xen/ > > gitignore: Create .gitignore file for docs/ > > gitignore: Create .gitignore file for stubdom/ > > gitignore: Create .gitignore file for config/ > > gitignore: Create .gitignore file for tools/ > > gitignore: RFC Prelimiary final cleanup of top-level .gitignore > > I'm confused about whether what I have in my inbox is complete and > consistent: 01-11 don't look to be "in reply to" this one, and they > all pre-date this mail by a varying number of days (Aug 27 ... Sep 3). > Additionally, unlike what happens for every other sender these days, > I've also got two copies of most (but not all) of them. Prior to our > mail setup over here having changed over a year ago this was the > normal way when I was Cc-ed on patches, but the server nowadays > de-duplicates the mails. So something is likely odd with your setup. I think there is a distinct chance I screwed up and got things mixed together (joy! more strong evidence I'm not all here, now to win that war to put me back together). -- (\___(\___(\______ --=> 8-) EHM <=-- ______/)___/)___/) \BS ( | ehem+sigmsg@m5p.com PGP 87145445 | ) / \_CS\ | _____ -O #include O- _____ | / _/ 8A19\___\_|_/58D2 7E3D DDF4 7BA6 <-PGP-> 41D1 B375 37D0 8714\_|_/___/5445