Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2CA4C43461 for ; Fri, 11 Sep 2020 06:58:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A30E8221EE for ; Fri, 11 Sep 2020 06:58:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725763AbgIKG6N (ORCPT ); Fri, 11 Sep 2020 02:58:13 -0400 Received: from helcar.hmeau.com ([216.24.177.18]:58982 "EHLO fornost.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725535AbgIKG6L (ORCPT ); Fri, 11 Sep 2020 02:58:11 -0400 Received: from gwarestrin.arnor.me.apana.org.au ([192.168.0.7]) by fornost.hmeau.com with smtp (Exim 4.92 #5 (Debian)) id 1kGd0F-0007u4-89; Fri, 11 Sep 2020 16:57:48 +1000 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Fri, 11 Sep 2020 16:57:47 +1000 Date: Fri, 11 Sep 2020 16:57:47 +1000 From: Herbert Xu To: Ard Biesheuvel Cc: linux-crypto@vger.kernel.org, "David S. Miller" , Greg Kroah-Hartman , Trond Myklebust , Anna Schumaker , "J. Bruce Fields" , Chuck Lever , Eric Biggers , Arnd Bergmann , netdev@vger.kernel.org, devel@driverdev.osuosl.org, linux-nfs@vger.kernel.org Subject: Re: [PATCH v3 0/7] crypto: mark ecb(arc4) skcipher as obsolete Message-ID: <20200911065747.GF32150@gondor.apana.org.au> References: <20200831151649.21969-1-ardb@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200831151649.21969-1-ardb@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org On Mon, Aug 31, 2020 at 06:16:42PM +0300, Ard Biesheuvel wrote: > RC4 hasn't aged very well, and is a poor fit for the skcipher API so it > would be good if we could get rid of the ecb(arc4) drivers in the kernel > at some point in the future. This prevents new users from creeping in, and > allows us to improve the skcipher API without having to care too much about > obsolete algorithms that may be difficult to support going forward. > > So let's get rid of any remaining in-kernel users, either by switching them > to the arc4 library API (for cases which simply cannot change algorithms, > e.g., WEP), or dropping the code entirely. Also remove the remaining h/w > accelerated implementations, and mark the generic s/w implementation as > obsolete in Kconfig. > > Changes since v2: > - depend on CRYPTO_USER_API not CRYPTO_USER > - rename CRYPTO_USER_ENABLE_OBSOLETE to CRYPTO_USER_API_ENABLE_OBSOLETE for > clarity > > Changes since RFC [0]: > - keep ecb(arc4) generic C implementation, and the associated test vectors, > but print a warning about ecb(arc4) being obsolete so we can identify > remaining users > - add a Kconfig option to en/disable obsolete algorithms that are only kept > around to prevent breaking users that rely on it via the socket interface > - add a patch to clean up some bogus Kconfig dependencies > - add acks to patches #1, #2 and #3 > > [0] https://lore.kernel.org/driverdev-devel/20200702101947.682-1-ardb@kernel.org/ > > Cc: Herbert Xu > Cc: "David S. Miller" > Cc: Greg Kroah-Hartman > Cc: Trond Myklebust > Cc: Anna Schumaker > Cc: "J. Bruce Fields" > Cc: Chuck Lever > Cc: Eric Biggers > Cc: Arnd Bergmann > Cc: linux-crypto@vger.kernel.org > Cc: netdev@vger.kernel.org > Cc: devel@driverdev.osuosl.org > Cc: linux-nfs@vger.kernel.org > > Ard Biesheuvel (7): > staging/rtl8192e: switch to RC4 library interface > staging/rtl8192u: switch to RC4 library interface > SUNRPC: remove RC4-HMAC-MD5 support from KerberosV > crypto: n2 - remove ecb(arc4) support > crypto: bcm-iproc - remove ecb(arc4) support > net: wireless: drop bogus CRYPTO_xxx Kconfig selects > crypto: arc4 - mark ecb(arc4) skcipher as obsolete > > crypto/Kconfig | 10 + > crypto/arc4.c | 10 + > drivers/crypto/bcm/cipher.c | 96 +----- > drivers/crypto/bcm/cipher.h | 1 - > drivers/crypto/bcm/spu.c | 23 +- > drivers/crypto/bcm/spu.h | 1 - > drivers/crypto/bcm/spu2.c | 12 +- > drivers/crypto/bcm/spu2.h | 1 - > drivers/crypto/n2_core.c | 46 --- > drivers/net/wireless/intel/ipw2x00/Kconfig | 4 - > drivers/net/wireless/intersil/hostap/Kconfig | 4 - > drivers/staging/rtl8192e/Kconfig | 4 +- > drivers/staging/rtl8192e/rtllib_crypt_tkip.c | 70 +---- > drivers/staging/rtl8192e/rtllib_crypt_wep.c | 72 +---- > drivers/staging/rtl8192u/Kconfig | 1 + > .../rtl8192u/ieee80211/ieee80211_crypt_tkip.c | 81 +---- > .../rtl8192u/ieee80211/ieee80211_crypt_wep.c | 64 +--- > include/linux/sunrpc/gss_krb5.h | 11 - > include/linux/sunrpc/gss_krb5_enctypes.h | 9 +- > net/sunrpc/Kconfig | 1 - > net/sunrpc/auth_gss/gss_krb5_crypto.c | 276 ------------------ > net/sunrpc/auth_gss/gss_krb5_mech.c | 95 ------ > net/sunrpc/auth_gss/gss_krb5_seal.c | 1 - > net/sunrpc/auth_gss/gss_krb5_seqnum.c | 87 ------ > net/sunrpc/auth_gss/gss_krb5_unseal.c | 1 - > net/sunrpc/auth_gss/gss_krb5_wrap.c | 65 +---- > 26 files changed, 97 insertions(+), 949 deletions(-) All applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt