Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB6E8C433E2 for ; Mon, 14 Sep 2020 02:08:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7051021655 for ; Mon, 14 Sep 2020 02:08:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725980AbgINCIT (ORCPT ); Sun, 13 Sep 2020 22:08:19 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:60540 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725965AbgINCIT (ORCPT ); Sun, 13 Sep 2020 22:08:19 -0400 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1kHdug-00EXQv-EK; Mon, 14 Sep 2020 04:08:14 +0200 Date: Mon, 14 Sep 2020 04:08:14 +0200 From: Andrew Lunn To: Vladimir Oltean Cc: Jakub Kicinski , davem@davemloft.net, netdev@vger.kernel.org, mkubecek@suse.cz, michael.chan@broadcom.com, tariqt@nvidia.com, saeedm@nvidia.com, alexander.duyck@gmail.com Subject: Re: [PATCH net-next v2 0/8] ethtool: add pause frame stats Message-ID: <20200914020814.GE3463198@lunn.ch> References: <20200911232853.1072362-1-kuba@kernel.org> <20200911234932.ncrmapwpqjnphdv5@skbuf> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200911234932.ncrmapwpqjnphdv5@skbuf> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > DSA used to override the "ethtool -S" callback of the host port, and > append its own CPU port counters to that. That was always a hack. It was bound to break sooner or later. Ido planned to add statistics to devlink. I hope we can make use of that to replace the CPU port statistics, and also add DSA port statistics, since these interfaces do exist in devlink. Andrew