Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA03FC433E2 for ; Mon, 14 Sep 2020 17:11:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 63F61206F4 for ; Mon, 14 Sep 2020 17:11:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600103484; bh=zN4FFsdqO776wgI3BWi5y1oH3U7OWzwgmnVohqMeufM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=Sgp6zhxac5MtDYjnlW9ND6pchLMiNPGr7wzo7H5BKf6c/WEb0Pl/oXkfWCJS8L5W1 y9BHRDc9u3a81JNQ9G60FmWmWgG2XWMORBjxsH1VK93sj2Qca6bMMO9j15jqIk965J vJwqk0NeKsU6KuCHVG8wneraz6BV1T3Pv3LUR09w= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726328AbgINRLK (ORCPT ); Mon, 14 Sep 2020 13:11:10 -0400 Received: from mail.kernel.org ([198.145.29.99]:60296 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726597AbgINNEt (ORCPT ); Mon, 14 Sep 2020 09:04:49 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EC878221E3; Mon, 14 Sep 2020 13:04:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600088656; bh=zN4FFsdqO776wgI3BWi5y1oH3U7OWzwgmnVohqMeufM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=sV/2enNKk1su63deBtbAUx4LySmyiqaGl2y5E5TYx9pWUL+Jj6NnQdoY8puirmSd/ uxcTGe4tl2gw0G3U11eNXDIeei1XAEQsjKZur/gncEUuC1ygsgE6VukTmGYjwoxeDf UxYRdeN+LaVl8/MF2DB3d3YZyaBdB/gJq3LtY554= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Laurent Pinchart , Randy Dunlap , Sasha Levin Subject: [PATCH AUTOSEL 5.8 15/29] rapidio: Replace 'select' DMAENGINES 'with depends on' Date: Mon, 14 Sep 2020 09:03:44 -0400 Message-Id: <20200914130358.1804194-15-sashal@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200914130358.1804194-1-sashal@kernel.org> References: <20200914130358.1804194-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Laurent Pinchart [ Upstream commit d2b86100245080cfdf1e95e9e07477474c1be2bd ] Enabling a whole subsystem from a single driver 'select' is frowned upon and won't be accepted in new drivers, that need to use 'depends on' instead. Existing selection of DMAENGINES will then cause circular dependencies. Replace them with a dependency. Signed-off-by: Laurent Pinchart Acked-by: Randy Dunlap Signed-off-by: Sasha Levin --- drivers/rapidio/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rapidio/Kconfig b/drivers/rapidio/Kconfig index e4c422d806bee..b9f8514909bf0 100644 --- a/drivers/rapidio/Kconfig +++ b/drivers/rapidio/Kconfig @@ -37,7 +37,7 @@ config RAPIDIO_ENABLE_RX_TX_PORTS config RAPIDIO_DMA_ENGINE bool "DMA Engine support for RapidIO" depends on RAPIDIO - select DMADEVICES + depends on DMADEVICES select DMA_ENGINE help Say Y here if you want to use DMA Engine frameork for RapidIO data -- 2.25.1