Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB091C43461 for ; Mon, 14 Sep 2020 14:32:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 81058207EA for ; Mon, 14 Sep 2020 14:32:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600093943; bh=zolZwzTxEfBeTWyu+h7YHfETfQ/DiytX4nDIsqj6itw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=1+oD1Uh0ptTLBFvho1BIHFQ15TX3f4c+sv6S0NdmtjbtGmNoS8xPJt4sXxN7MgrNa TfsLmad0rY6ybKyaKgl1mY9uMNxwsRSK6PnrHtiRbEQibfD/5wxnsNZD8c20mFTTGj tqiE1TGPdqlaPZYGH8V9Bu9m+2HIkEkG998PrxxA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726709AbgINOcV (ORCPT ); Mon, 14 Sep 2020 10:32:21 -0400 Received: from mail.kernel.org ([198.145.29.99]:60294 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726651AbgINNGA (ORCPT ); Mon, 14 Sep 2020 09:06:00 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4BAF822261; Mon, 14 Sep 2020 13:05:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600088713; bh=zolZwzTxEfBeTWyu+h7YHfETfQ/DiytX4nDIsqj6itw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=r7toSJuwWGlKc8MNZdhoCdySx1pMuhZctGY6Lria1fDqWKDA1UcZhV9EBL/6y/4T7 5aADrGvymapWgiO0P331afC5WT/C3UMc8u8E3hHJtbgndwGJ5znwAqwmrnHm8WHr2Y L4NMpBLcNcULLPQ8K4cCUQh9FQxnAuuUO8ZNfNn0= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Laurent Pinchart , Randy Dunlap , Sasha Levin Subject: [PATCH AUTOSEL 4.19 09/19] rapidio: Replace 'select' DMAENGINES 'with depends on' Date: Mon, 14 Sep 2020 09:04:52 -0400 Message-Id: <20200914130502.1804708-9-sashal@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200914130502.1804708-1-sashal@kernel.org> References: <20200914130502.1804708-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Laurent Pinchart [ Upstream commit d2b86100245080cfdf1e95e9e07477474c1be2bd ] Enabling a whole subsystem from a single driver 'select' is frowned upon and won't be accepted in new drivers, that need to use 'depends on' instead. Existing selection of DMAENGINES will then cause circular dependencies. Replace them with a dependency. Signed-off-by: Laurent Pinchart Acked-by: Randy Dunlap Signed-off-by: Sasha Levin --- drivers/rapidio/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rapidio/Kconfig b/drivers/rapidio/Kconfig index d6d2f20c45977..21df2816def76 100644 --- a/drivers/rapidio/Kconfig +++ b/drivers/rapidio/Kconfig @@ -25,7 +25,7 @@ config RAPIDIO_ENABLE_RX_TX_PORTS config RAPIDIO_DMA_ENGINE bool "DMA Engine support for RapidIO" depends on RAPIDIO - select DMADEVICES + depends on DMADEVICES select DMA_ENGINE help Say Y here if you want to use DMA Engine frameork for RapidIO data -- 2.25.1