Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C68BCC43461 for ; Mon, 14 Sep 2020 23:50:44 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3D492206A5 for ; Mon, 14 Sep 2020 23:50:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="KVH0dF3l" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3D492206A5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 841656E185; Mon, 14 Sep 2020 23:50:43 +0000 (UTC) Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by gabe.freedesktop.org (Postfix) with ESMTPS id 76EC66E185 for ; Mon, 14 Sep 2020 23:50:42 +0000 (UTC) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 0EA51275; Tue, 15 Sep 2020 01:50:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1600127439; bh=iNsUVoOpimtPMpsh7LHnXpgXant0qZ7noNfJYzDAiGo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=KVH0dF3lCBMEelfW/yL36CLM5YPgv+PZVSZEAEE6NEMKTPVnvX4lYd54ZRrn0SLpe FTMil3hTIMXEpfvGsdC4XmAo2WCHAsdBGPvTFCRHwB4hNx2DxsRTdzUxd9sY2SxVjM CT5zEDbdVTM5AaZlQJeDHuVU4NWah/O8o++taL+8= Date: Tue, 15 Sep 2020 02:50:11 +0300 From: Laurent Pinchart To: Jyri Sarha Subject: Re: [PATCH 1/2] drm/tilcdc: Do not keep vblank interrupts enabled all the time Message-ID: <20200914235011.GK15543@pendragon.ideasonboard.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: tomi.valkeinen@ti.com, dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Jyri, Thank you for the patch. On Mon, Sep 14, 2020 at 11:34:49AM +0300, Jyri Sarha wrote: > END_OF_FRAME interrupts have been enabled all the time since the > beginning of this driver. It is about time to add this feature. > > Signed-off-by: Jyri Sarha Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 36 +++++++++++++++++++++++++--- > 1 file changed, 33 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/tilcdc/tilcdc_crtc.c b/drivers/gpu/drm/tilcdc/tilcdc_crtc.c > index 1856962411c7..29f263e1975a 100644 > --- a/drivers/gpu/drm/tilcdc/tilcdc_crtc.c > +++ b/drivers/gpu/drm/tilcdc/tilcdc_crtc.c > @@ -147,12 +147,9 @@ static void tilcdc_crtc_enable_irqs(struct drm_device *dev) > tilcdc_set(dev, LCDC_RASTER_CTRL_REG, > LCDC_V1_SYNC_LOST_INT_ENA | LCDC_V1_FRAME_DONE_INT_ENA | > LCDC_V1_UNDERFLOW_INT_ENA); > - tilcdc_set(dev, LCDC_DMA_CTRL_REG, > - LCDC_V1_END_OF_FRAME_INT_ENA); > } else { > tilcdc_write(dev, LCDC_INT_ENABLE_SET_REG, > LCDC_V2_UNDERFLOW_INT_ENA | > - LCDC_V2_END_OF_FRAME0_INT_ENA | > LCDC_FRAME_DONE | LCDC_SYNC_LOST); > } > } > @@ -678,11 +675,44 @@ static int tilcdc_crtc_atomic_check(struct drm_crtc *crtc, > > static int tilcdc_crtc_enable_vblank(struct drm_crtc *crtc) > { > + struct tilcdc_crtc *tilcdc_crtc = to_tilcdc_crtc(crtc); > + struct drm_device *dev = crtc->dev; > + struct tilcdc_drm_private *priv = dev->dev_private; > + unsigned long flags; > + > + spin_lock_irqsave(&tilcdc_crtc->irq_lock, flags); > + > + tilcdc_clear_irqstatus(dev, LCDC_END_OF_FRAME0); > + > + if (priv->rev == 1) > + tilcdc_set(dev, LCDC_DMA_CTRL_REG, > + LCDC_V1_END_OF_FRAME_INT_ENA); > + else > + tilcdc_set(dev, LCDC_INT_ENABLE_SET_REG, > + LCDC_V2_END_OF_FRAME0_INT_ENA); > + > + spin_unlock_irqrestore(&tilcdc_crtc->irq_lock, flags); > + > return 0; > } > > static void tilcdc_crtc_disable_vblank(struct drm_crtc *crtc) > { > + struct tilcdc_crtc *tilcdc_crtc = to_tilcdc_crtc(crtc); > + struct drm_device *dev = crtc->dev; > + struct tilcdc_drm_private *priv = dev->dev_private; > + unsigned long flags; > + > + spin_lock_irqsave(&tilcdc_crtc->irq_lock, flags); > + > + if (priv->rev == 1) > + tilcdc_clear(dev, LCDC_DMA_CTRL_REG, > + LCDC_V1_END_OF_FRAME_INT_ENA); > + else > + tilcdc_clear(dev, LCDC_INT_ENABLE_SET_REG, > + LCDC_V2_END_OF_FRAME0_INT_ENA); > + > + spin_unlock_irqrestore(&tilcdc_crtc->irq_lock, flags); > } > > static void tilcdc_crtc_reset(struct drm_crtc *crtc) -- Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel